-
Notifications
You must be signed in to change notification settings - Fork 730
server: refactor params of askSplit
call
#8537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @qingfeng777! |
Hi @qingfeng777. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8537 +/- ##
==========================================
- Coverage 77.55% 77.50% -0.05%
==========================================
Files 474 474
Lines 61861 61856 -5
==========================================
- Hits 47974 47942 -32
- Misses 10355 10373 +18
- Partials 3532 3541 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
askSplit
call. (#8462)askSplit
call
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Close #5014
What is changed and how does it work?
refactor params of
askSplit
call in grpc_service.goCheck List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note