Skip to content

server/grpc_service: new AskSplitRequest could be removed #5014

Closed
@AndreMouche

Description

Enhancement Task

It seems we do not need to create a new AskSplit in the function AskSplitRegion, use request directly instead.

pd/server/grpc_service.go

Lines 1066 to 1072 in 9f10a51

if request.GetRegion() == nil {
return nil, errors.New("missing region for split")
}
req := &pdpb.AskSplitRequest{
Region: request.Region,
}
split, err := rc.HandleAskSplit(req)

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.type/enhancementThe issue or PR belongs to an enhancement.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions