Skip to content

server: fix inappropriate log level #8462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024
Merged

server: fix inappropriate log level #8462

merged 2 commits into from
Jul 31, 2024

Conversation

Jackl9u
Copy link
Contributor

@Jackl9u Jackl9u commented Jul 31, 2024

What problem does this PR solve?

Issue Number: Ref #8453

What is changed and how does it work?

changed log.Error to log.Warn, since it's a warning

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Boyang Lyu <boyangly@gmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

Welcome @Jackl9u!

It looks like this is your first PR to tikv/pd 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/pd. 😃

Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

Hi @Jackl9u. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2024
@HuSharp
Copy link
Member

HuSharp commented Jul 31, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (84f90f4) to head (e05a2bf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8462      +/-   ##
==========================================
+ Coverage   77.29%   77.34%   +0.05%     
==========================================
  Files         472      472              
  Lines       61796    61796              
==========================================
+ Hits        47764    47797      +33     
+ Misses      10461    10431      -30     
+ Partials     3571     3568       -3     
Flag Coverage Δ
unittests 77.34% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-31 07:50:05.865542695 +0000 UTC m=+342122.145590764: ☑️ agreed by JmPotato.
  • 2024-07-31 08:03:41.820771819 +0000 UTC m=+342938.100819888: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot merged commit 45dac53 into tikv:master Jul 31, 2024
25 checks passed
qingfeng777 added a commit to qingfeng777/pd that referenced this pull request Aug 15, 2024
Signed-off-by: qingfeng777 <251098199@qq.com>
qingfeng777 added a commit to qingfeng777/pd that referenced this pull request Aug 20, 2024
Signed-off-by: qingfeng777 <251098199@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants