Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_debug_msgs): add SystemUsageArray #144

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 25, 2024

Related Links

autowarefoundation/autoware_tools#85

Description

Added messages to track the CPU usage and memory usage.
autowarefoundation/autoware_tools#85 depends on this PR.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@mitsudome-r
Copy link
Collaborator

mitsudome-r commented Jul 25, 2024

We have a similar message in autoware_internal_msgs. Should we modify this message instead of adding a new one under tier4_messages?
https://github.com/autowarefoundation/autoware_internal_msgs/blob/main/msg/ResourceUsageReport.msg

@takayuki5168
Copy link
Contributor Author

@mitsudome-r
This message was introduced for debugging purposes for now. The autoware.unvierse/autoware_launch does not depend on this message, and only autoware_tools and TIER IV's scripts depend on it. Also, we may still change the message. These are the reason I put this message in tier4_debug_msgs.

In the future, after the message is fully determined, of course I'm fine with putting this message and the message in autoware_internal_msgs together.

Copy link
Collaborator

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit 8c7cd26 into tier4/universe Jul 25, 2024
12 checks passed
@mitsudome-r mitsudome-r deleted the feat/system-usage-array branch July 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants