Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main for galactic release #25

Merged
merged 34 commits into from
Aug 31, 2022
Merged
Changes from 2 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
0661239
feat(stop_accel_evaluator): use flexible lpf
takayuki5168 Jul 7, 2022
b0ec9b7
fix pr template
yabuta Jul 7, 2022
2029d85
Merge pull request #4 from tier4/feature/fix_template
yabuta Jul 7, 2022
dbe7884
fix: x1 base-lidar launcher
knzo25 Jul 7, 2022
6eb3714
Merge pull request #5 from tier4/fix/x1_base_lidar_launcher
knzo25 Jul 7, 2022
a9c0fb8
fix(deviation_evaluator): debugged map_launch in launch file
kminoda Jul 7, 2022
925fbc4
fix README to refer to own repos file
aohsato Jul 7, 2022
a00c94d
fix repos file to fit autoware build process
aohsato Jul 7, 2022
a3111bd
fix calibration_tools url
aohsato Jul 7, 2022
4d29700
remove installation from sensor/readme
aohsato Jul 7, 2022
25b3e7d
modify readme urls to relative path
aohsato Jul 7, 2022
84e41fe
fix(deviation_estimation_tools): fix a bug in loading parameter file
kminoda Jul 8, 2022
12e67da
reverted a change around map loader
kminoda Jul 8, 2022
196e509
revert readme modification
kminoda Jul 8, 2022
9e95235
changed param file name in launch file
kminoda Jul 8, 2022
a93d228
fix(deviation_estimation_tools): added a neccesary topic name in readme
kminoda Jul 8, 2022
1430972
Merge pull request #8 from tier4/fix/deviation_estimation_tools_param…
kminoda Jul 8, 2022
65b5baf
Merge branch 'tier4/universe' into fix/deviation_estimation_tools_readme
kminoda Jul 8, 2022
2732df5
Merge pull request #9 from tier4/fix/deviation_estimation_tools_readme
kminoda Jul 9, 2022
7ee3d36
Merge branch 'tier4/universe' into fix/readme_repos
aohsato Jul 11, 2022
a8ad0d1
Merge pull request #7 from tier4/fix/readme_repos
aohsato Jul 11, 2022
040dda9
feat: sensor documentation (#14)
knzo25 Jul 15, 2022
9766e22
Merge branch 'tier4/universe' into fix/map_launch_in_localization_tool
kminoda Jul 15, 2022
a958bb9
Merge pull request #6 from tier4/fix/map_launch_in_localization_tool
kminoda Jul 15, 2022
63c5f81
add COLCON_IGNORE
yabuta Jul 19, 2022
3863d4b
Merge pull request #15 from tier4/feature/temp_ignore_stop_accel_eval…
yabuta Jul 19, 2022
baf87d0
add action
yabuta Jul 19, 2022
ff3a21d
pre commit
yabuta Jul 19, 2022
5c5fbd0
fix
yabuta Jul 20, 2022
4a57bf0
feat(map based calibrator): added 6dig search (#10)
YoheiMishina Jul 27, 2022
37c70bc
Merge branch 'tier4/universe' into feature/add_sync_humble
yabuta Jul 28, 2022
0374b09
Merge pull request #16 from tier4/feature/add_sync_humble
yabuta Jul 28, 2022
e26a1d2
Merge branch 'tier4/universe' into feat/apply-flexible-lpf
takayuki5168 Jul 29, 2022
e5a9117
Merge pull request #3 from tier4/feat/apply-flexible-lpf
yabuta Jul 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 24 additions & 37 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,55 +1,42 @@
## PR Type

<!-- Select one and remove others. If an appropriate one is not listed, please write by yourself. -->

- New Feature
- Improvement
- Bug Fix

## Related Links

<!-- Please write related links to GitHub/Jira/Slack/etc. -->

## Description

<!-- Describe what this PR changes. -->
<!-- Write a brief description of this PR. -->

## Related links

## Review Procedure
<!-- Write the links related to this PR. -->

<!-- Explain how to review this PR. -->
## Tests performed

## Remarks
<!-- Describe how you have tested this PR. -->

<!-- Write remarks as you like if you need them. -->
## Notes for reviewers

## Pre-Review Checklist for the PR Author
<!-- Write additional information if necessary. It should be written if there are related PRs that should be merged at the same time. -->

**PR Author should check the checkboxes below when creating the PR.**
## Pre-review checklist for the PR author

- [ ] Code follows [coding guidelines][coding-guidelines]
- [ ] Assign PR to reviewer
The PR author **must** check the checkboxes below when creating the PR.

## Checklist for the PR Reviewer
- [ ] I've confirmed the [contribution guidelines].
- [ ] The PR follows the [pull request guidelines].

**Reviewers should check the checkboxes below before approval.**
## In-review checklist for the PR reviewers

- [ ] Commits are properly organized and messages are according to the guideline
- [ ] Code follows [coding guidelines][coding-guidelines]
- [ ] (Optional) Unit tests have been written for new behavior
- [ ] PR title describes the changes
The PR reviewers **must** check the checkboxes below before approval.

## Post-Review Checklist for the PR Author
- [ ] The PR follows the [pull request guidelines].
- [ ] The PR has been properly tested.
- [ ] The PR has been reviewed by the code owners.

**PR Author should check the checkboxes below before merging.**
## Post-review checklist for the PR author

- [ ] All open points are addressed and tracked via issues or tickets
- [ ] Write [release notes][release-notes]
The PR author **must** check the checkboxes below before merging.

## CI Checks
- [ ] There are no open discussions or they are tracked via tickets.
- [ ] The PR is ready for merge.

- **Build and test for PR**: Required to pass before the merge.
- **Check spelling**: NOT required to pass before the merge. It is up to the reviewer(s). See [here][spell-check-dict] if you want to add some words to the spell check dictionary.
After all checkboxes are checked, anyone who has write access can merge the PR.

[coding-guidelines]: https://tier4.atlassian.net/wiki/spaces/AIP/pages/1194394777/T4
[release-notes]: https://tier4.atlassian.net/l/c/X1p69s6B
[spell-check-dict]: https://github.com/tier4/autoware-spell-check-dict#how-to-contribute
[contribution guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/
[pull request guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/