-
Notifications
You must be signed in to change notification settings - Fork 24
register tune_args()
and tunable()
methods unconditionally
#193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seemed okay from my end, but worth double checking that this is indeed still the case with the changes in tidymodels/recipes#1087: Lines 14 to 16 in cce255e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is required_pkgs()
part of this PR? 🤔
re tune_args()
and tunable()
: When I moved them here, I originally also (re)exported the generic but @DavisVaughan suggested not to do that. IIRC, the reasoning was that you only really call those functions once you are in {tune} but not when you have only {workflows} loaded. #123 (comment)
I think this still holds so I'd remove the @export
tag from the imported generics (not the methods, of course)
I would not re-export any of the generics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
As an additional comment, not part of this PR: there are tests for tune_args()
and tunable()
methods in extratests:
- https://github.com/tidymodels/extratests/blob/main/tests/testthat/test-tune_args.R
- https://github.com/tidymodels/extratests/blob/main/tests/testthat/test-tunable.R
do you think it's worth consolidating them with the tests here?
Certainly worth looking into. :) Just opened up a separate issue, thanks! |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Closes #192. :)