-
Notifications
You must be signed in to change notification settings - Fork 24
move method for tune_args()
from tune to here
#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
commented
Oct 8, 2021
This was referenced Oct 8, 2021
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Davis Vaughan <davis@rstudio.com>
from code review
topepo
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing for me beyond Davis's comments.
DavisVaughan
approved these changes
Oct 19, 2021
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of moving methods for
tune_args()
from tune to the package which holds the corresponding object class:recipe
,step
, andcheck
are moved to recipes move methods fortune_args()
from tune to here recipes#830model_spec
is moved to parsnip move method fortune_args()
from tune to here parsnip#571workflow
is moved to workflows (aka this PR here)In all cases, the methods are registered conditionally on the version of tune from which the methods have been removed. The tune PR is tidymodels/tune#420
The tests require multiple packages so they are all in extratests: tidymodels/extratests#30
The PR on extratests should be merged first, then the ones on recipes and parsnip, then workflows, then tune.
This is part of the wider aim of introducing
extract_parameter_dials()
andextract_parameter_set_dials()
and the next steps are:tunable()
similar to this PR setparameters()
similar to this PR setextract_parameter_set_dials()
extract_parameter_dials()