Skip to content

remove methods for tune_args() and associated tests #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 26, 2021

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Oct 11, 2021

This PR is part of moving methods for tune_args() from tune to the package which holds the corresponding object class:

In all cases, the methods are registered conditionally on the version of tune from which the methods have been removed. The tune PR is this PR here.

The tests require multiple packages so they are all in extratests: tidymodels/extratests#30

The PR on extratests should be merged first, then the ones on recipes and parsnip, then workflows, then tune.

This is part of the wider aim of introducing extract_parameter_dials() and extract_parameter_set_dials() and the next steps are:

  • moving the methods for tunable() similar to this PR set
  • moving the methods for parameters() similar to this PR set
  • introducing extract_parameter_set_dials()
  • introducing extract_parameter_dials()
  • updating documentation and learning materials

@hfrick hfrick requested a review from juliasilge October 12, 2021 15:32
Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me 👍

@hfrick hfrick merged commit 696ef36 into master Oct 26, 2021
@hfrick hfrick deleted the remove-tune_args-methods branch October 26, 2021 12:22
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants