Skip to content

register tune_args() and tunable() methods unconditionally #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

simonpcouch
Copy link
Contributor

Similar rationale and implementation as tidymodels/workflows#193. :)

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about code duplication 👍

@topepo topepo merged commit 7a2f73a into main Feb 16, 2023
@topepo topepo deleted the register-tune branch February 16, 2023 17:54
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants