Skip to content

[Dashboard] Remove AddressCopyButton #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 18, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on removing the AddressCopyButton component from various files and replacing it with the CopyTextButton and CopyAddressButton components to optimize bundle size and improve code consistency.

Detailed summary

  • Deleted AddressCopyButton.tsx.
  • Removed all imports of AddressCopyButton from multiple files.
  • Replaced instances of AddressCopyButton with CopyTextButton or CopyAddressButton in:
    • webhooks-table.tsx
    • token-id.tsx
    • transaction-timeline.tsx
    • contract-subscriptions-table.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 9:02am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 19, 2024 9:02am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 19, 2024 9:02am
wallet-ui ⬜️ Skipped (Inspect) Oct 19, 2024 9:02am

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: f2d1085

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 07:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 07:34 Inactive
Copy link
Contributor

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

kien-ngo commented Oct 18, 2024

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 18, 2024
@kien-ngo kien-ngo changed the title Update [Dashboard] Remove AddressCopyButton Oct 18, 2024
@kien-ngo kien-ngo marked this pull request as ready for review October 18, 2024 07:34
Copy link
Contributor

github-actions bot commented Oct 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 420 ms (+90.96% 🔺) 1.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 469 ms (-12.25% 🔽) 2.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 14 ms (-19.16% 🔽) 111 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 69 ms (+934.01% 🔺) 79 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 86 ms (+52.46% 🔺) 433 ms

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (a68830c) to head (f2d1085).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5077   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54729    54729           
  Branches     3956     3956           
=======================================
  Hits        24789    24789           
  Misses      29249    29249           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a68830c
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@kien-ngo kien-ngo force-pushed the kien/add-token-uri-nft branch from db71142 to cd81893 Compare October 18, 2024 07:51
@kien-ngo kien-ngo requested a review from gregfromstl as a code owner October 18, 2024 07:51
@kien-ngo kien-ngo force-pushed the kien/remove-AddressCopyButton branch from 51b01c5 to 042354e Compare October 18, 2024 07:51
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 07:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 07:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 07:52 Inactive
@kien-ngo kien-ngo force-pushed the kien/add-token-uri-nft branch from cd81893 to b75cb9d Compare October 18, 2024 08:09
@kien-ngo kien-ngo force-pushed the kien/remove-AddressCopyButton branch from 042354e to 9a68582 Compare October 18, 2024 08:09
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 14:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 14:28 Inactive
@kien-ngo kien-ngo force-pushed the kien/remove-AddressCopyButton branch from 14ea4b3 to 5f14dd0 Compare October 18, 2024 14:32
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 14:32 Inactive
@kien-ngo kien-ngo requested a review from MananTank October 18, 2024 14:47
@MananTank MananTank force-pushed the kien/add-token-uri-nft branch from 9ef602f to 4542a48 Compare October 18, 2024 23:59
Base automatically changed from kien/add-token-uri-nft to main October 19, 2024 00:09
@MananTank MananTank force-pushed the kien/remove-AddressCopyButton branch from 5f14dd0 to 986cf6b Compare October 19, 2024 00:10
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 19, 2024 00:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 19, 2024 00:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 19, 2024 00:10 Inactive
Copy link
Contributor

graphite-app bot commented Oct 19, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on removing the `AddressCopyButton` component from various files and replacing it with `CopyTextButton` and `CopyAddressButton` components to optimize bundle size and improve code consistency.

### Detailed summary
- Deleted `AddressCopyButton.tsx` file.
- Removed all imports of `AddressCopyButton` from multiple files.
- Replaced instances of `AddressCopyButton` with `CopyTextButton` in `webhooks-table.tsx` and `token-id.tsx`.
- Replaced `AddressCopyButton` with `CopyAddressButton` in `transaction-timeline.tsx` and `contract-subscriptions-table.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/remove-AddressCopyButton branch from 986cf6b to f2d1085 Compare October 19, 2024 08:52
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 19, 2024 08:52 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 19, 2024 08:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 19, 2024 08:52 Inactive
@graphite-app graphite-app bot merged commit f2d1085 into main Oct 19, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/remove-AddressCopyButton branch October 19, 2024 09:02
@vercel vercel bot temporarily deployed to Production – docs-v2 October 19, 2024 09:02 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 19, 2024 09:02 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 19, 2024 09:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants