[Dashboard] Remove unnecessary chakra-ui Tabs in Listing sheet #5076

kien-ngo · 2024-10-18T06:20:18Z

Remove unnecessary Tabs, just put the button at the bottom, since there's ever been only 1 tab anyway

PR-Codex overview

This PR focuses on refactoring the marketplace components in the application by removing unused components, consolidating functionality, and improving the user interface for listing details and cancellations.

Detailed summary

Deleted CancelDirectListing.tsx and CancelEnglishAuction.tsx.
Modified MarketplaceTable to remove type prop.
Updated cancellation handling in CancelTab to use toast for notifications.
Replaced direct listing and auction cancellation with a unified CancelTab.
Enhanced ListingDrawer to utilize CopyAddressButton and CopyTextButton.
Removed redundant tab structure in ListingDrawer, simplifying the layout.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-18T06:20:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 7:49am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Oct 18, 2024 7:49am
thirdweb_playground	⬜️ Skipped (Inspect)	Oct 18, 2024 7:49am
wallet-ui	⬜️ Skipped (Inspect)	Oct 18, 2024 7:49am

changeset-bot · 2024-10-18T06:20:22Z

⚠️ No Changeset found

Latest commit: 1cd11a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-18T06:20:24Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-10-18T06:20:34Z

[Dashboard] Remove AddressCopyButton #5077
[Dashboard] Add tokenURI section to the NFT page #5035
[Dashboard] Remove unnecessary chakra-ui Tabs in Listing sheet #5076 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

codecov · 2024-10-18T06:22:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (9da5cd7) to head (1cd11a8).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5076   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54728    54728           
  Branches     3954     3954           
=======================================
  Hits        24791    24791           
  Misses      29246    29246           
  Partials      691      691

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 9da5cd7
packages	`40.24% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-10-18T06:24:22Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.81 KB (0%)	857 ms (0%)	3.3 s (+45.86% 🔺)	4.1 s
thirdweb (cjs)	102.66 KB (0%)	2.1 s (0%)	4.8 s (-0.28% 🔽)	6.9 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	294 ms (+83.55% 🔺)	390 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	106 ms (+129.3% 🔺)	116 ms
thirdweb/react (minimal + tree-shaking)	17.36 KB (0%)	348 ms (0%)	844 ms (+64.73% 🔺)	1.2 s

jnsdls · 2024-10-18T06:28:19Z

...(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/components/listing-drawer.tsx

-      {
-        title: "Cancel Listing",
-        isDisabled: !isOwner,


what happens to this second tab?

graphite-app · 2024-10-18T07:46:15Z

Merge activity

Oct 18, 3:46 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 18, 3:50 AM EDT: A user merged this pull request with the Graphite merge queue.

Remove unnecessary Tabs, just put the button at the bottom, since there's ever been only 1 tab anyway ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/VtULqGKSp33n0VHOzNJK/53a75b30-20b2-471c-9566-4b022a96b616.png)  --- ## PR-Codex overview This PR focuses on refactoring the marketplace components by removing unused files and consolidating the listing cancellation functionality into a single component, `CancelTab`. It also enhances the `ListingDrawer` component with improved UI elements for displaying asset information. ### Detailed summary - Deleted `CancelDirectListing.tsx` and `CancelEnglishAuction.tsx`. - Introduced `CancelTab` for handling cancellation of listings and auctions. - Updated `ListingDrawer` to use `CancelTab`. - Replaced `useTxNotifications` with `toast` for transaction feedback. - Added `CopyAddressButton` and `CopyTextButton` for better user interaction. - Refactored asset details display in `ListingDrawer` for improved readability. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 06:20 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 06:20 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 06:20 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 18, 2024

kien-ngo marked this pull request as ready for review October 18, 2024 06:20

kien-ngo requested review from jnsdls, MananTank and joaquim-verges as code owners October 18, 2024 06:20

jnsdls reviewed Oct 18, 2024

View reviewed changes

vercel bot deployed to Preview – thirdweb-www October 18, 2024 06:30 View deployment

jnsdls approved these changes Oct 18, 2024

View reviewed changes

kien-ngo force-pushed the kien/remove-unnecessary-tabs-on-listing-sheet branch from ffb0218 to 1de77eb Compare October 18, 2024 07:15

vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 07:16 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 07:16 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 07:16 Inactive

kien-ngo force-pushed the kien/remove-unnecessary-tabs-on-listing-sheet branch from 1de77eb to a0db8a0 Compare October 18, 2024 07:23

vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 07:23 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 07:23 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 07:24 Inactive

kien-ngo force-pushed the kien/remove-unnecessary-tabs-on-listing-sheet branch from a0db8a0 to 623543e Compare October 18, 2024 07:29

vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 07:29 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 07:29 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 07:29 Inactive

kien-ngo mentioned this pull request Oct 18, 2024

[Dashboard] Add tokenURI section to the NFT page #5035

Merged

kien-ngo mentioned this pull request Oct 18, 2024

[Dashboard] Remove AddressCopyButton #5077

Merged

vercel bot deployed to Preview – thirdweb-www October 18, 2024 07:46 View deployment

kien-ngo force-pushed the kien/remove-unnecessary-tabs-on-listing-sheet branch from 623543e to 1cd11a8 Compare October 18, 2024 07:46

vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 07:46 Inactive

vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 07:46 Inactive

vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 07:46 Inactive

vercel bot deployed to Preview – thirdweb-www October 18, 2024 07:49 View deployment

graphite-app bot merged commit 1cd11a8 into main Oct 18, 2024
30 checks passed

graphite-app bot deleted the kien/remove-unnecessary-tabs-on-listing-sheet branch October 18, 2024 07:50

vercel bot temporarily deployed to Production – wallet-ui October 18, 2024 07:50 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground October 18, 2024 07:50 Inactive

vercel bot temporarily deployed to Production – docs-v2 October 18, 2024 07:50 Inactive

vercel bot deployed to Production – thirdweb-www October 18, 2024 08:00 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard] Remove unnecessary chakra-ui Tabs in Listing sheet #5076

[Dashboard] Remove unnecessary chakra-ui Tabs in Listing sheet #5076

kien-ngo commented Oct 18, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 18, 2024 •

edited

Loading

changeset-bot bot commented Oct 18, 2024 •

edited

Loading

graphite-app bot commented Oct 18, 2024

kien-ngo commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

jnsdls Oct 18, 2024

graphite-app bot commented Oct 18, 2024 •

edited by kien-ngo

Loading

[Dashboard] Remove unnecessary chakra-ui Tabs in Listing sheet #5076

[Dashboard] Remove unnecessary chakra-ui Tabs in Listing sheet #5076

Conversation

kien-ngo commented Oct 18, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

vercel bot commented Oct 18, 2024 • edited Loading

changeset-bot bot commented Oct 18, 2024 • edited Loading

⚠️ No Changeset found

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

kien-ngo commented Oct 18, 2024 • edited Loading

codecov bot commented Oct 18, 2024 • edited Loading

Codecov Report

github-actions bot commented Oct 18, 2024 • edited Loading

size-limit report 📦

jnsdls Oct 18, 2024

Choose a reason for hiding this comment

graphite-app bot commented Oct 18, 2024 • edited by kien-ngo Loading

Merge activity

kien-ngo commented Oct 18, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 18, 2024 •

edited

Loading

changeset-bot bot commented Oct 18, 2024 •

edited

Loading

kien-ngo commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

graphite-app bot commented Oct 18, 2024 •

edited by kien-ngo

Loading