Skip to content

[Dashboard] Add tokenURI section to the NFT page #5035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 15, 2024

image

PR-Codex overview

This PR enhances the TokenIdPage component by adding functionality to display and copy the NFT's token URI. It introduces a CopyTextButton for easy copying, and a link to open the token URI in a new tab.

Detailed summary

  • Added CopyTextButton for copying the NFT's token URI.
  • Introduced a button with a link to open the token URI using ExternalLinkIcon.
  • Utilized shortenString to display a shortened version of the token URI.
  • Added new layout elements to present the token URI in the UI.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 0:09am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 19, 2024 0:09am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 19, 2024 0:09am
wallet-ui ⬜️ Skipped (Inspect) Oct 19, 2024 0:09am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 11:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 11:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 11:17 Inactive
Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: 4542a48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review October 15, 2024 11:17
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 15, 2024
Copy link
Contributor Author

kien-ngo commented Oct 15, 2024

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (17127d7) to head (4542a48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5035   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54729    54729           
  Branches     3956     3956           
=======================================
  Hits        24791    24791           
  Misses      29247    29247           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 17127d7
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 3 s (-22.96% 🔽) 3.8 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 6.7 s (+1.24% 🔺) 8.7 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 200 ms (-55.18% 🔽) 297 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 71 ms (+42.07% 🔺) 81 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 1.1 s (+148.89% 🔺) 1.5 s

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments

@kien-ngo kien-ngo force-pushed the kien/add-token-uri-nft branch from b75cb9d to 9ef602f Compare October 18, 2024 14:27
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 14:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 14:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 14:27 Inactive
@kien-ngo kien-ngo requested a review from MananTank October 18, 2024 14:28
Copy link
Contributor

graphite-app bot commented Oct 18, 2024

Merge activity

<img width="1172" alt="image" src="https://github.com/user-attachments/assets/bef8ec5b-b453-43e1-bc90-f7156b3dd578">

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `TokenIdPage` component by adding functionality for displaying and copying the token URI of an NFT. It introduces a `CopyTextButton` and a link that opens the token URI in a new tab, improving user interaction and accessibility.

### Detailed summary
- Added import for `CopyTextButton`.
- Added import for `ExternalLinkIcon`.
- Introduced `Link` from `next/link`.
- Added `token URI` section in the UI.
- Implemented `CopyTextButton` to copy the `nft.tokenURI`.
- Added a button with a link that opens the `nft.tokenURI` in a new tab.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the kien/add-token-uri-nft branch from 9ef602f to 4542a48 Compare October 18, 2024 23:59
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 18, 2024 23:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 18, 2024 23:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 18, 2024 23:59 Inactive
@graphite-app graphite-app bot merged commit 4542a48 into main Oct 19, 2024
31 checks passed
@graphite-app graphite-app bot deleted the kien/add-token-uri-nft branch October 19, 2024 00:09
@vercel vercel bot temporarily deployed to Production – docs-v2 October 19, 2024 00:09 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 19, 2024 00:09 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 19, 2024 00:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants