Skip to content

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 15, 2025

Changes

There was still a few references that makes the CI fail. This should fix it.

/cc @afrittoli @twoGiants @waveywaves

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 15, 2025
@tekton-robot
Copy link
Collaborator

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: twoGiants.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

There was still a few references that makes the CI fail. This should fix it.

/cc @afrittoli @twoGiants @waveywaves

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2025
Copy link
Member

@twoGiants twoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved.

@vdemeester
Copy link
Member Author

/retest

@twoGiants
Copy link
Member

/kind cleanup

@vdemeester vdemeester force-pushed the fix-e2e-rm-gcrio branch 3 times, most recently from 849de30 to ff031c0 Compare July 16, 2025 09:09
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2025
@vdemeester vdemeester force-pushed the fix-e2e-rm-gcrio branch 3 times, most recently from 16d43a7 to ff00683 Compare July 16, 2025 10:56
@vdemeester
Copy link
Member Author

hmm. I don't understand the failures now…

@vdemeester
Copy link
Member Author

/retest

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdemeester I think we need to fix step action. It refers to git-init catalog from gcr.

PS: I just saw that it was updated in catalog.

@vdemeester
Copy link
Member Author

@vdemeester I think we need to fix step action. It refers to git-init catalog from gcr.

It is fixed on catalog now.

@vdemeester
Copy link
Member Author

ahhh I messed up the parameters… it should be green now 🙃

@afrittoli
Copy link
Member

arendelle-rn6gp              48s         Normal    Started                        taskrun/http-resolver-kz4pn-http-resolver                                 
arendelle-rn6gp              48s         Warning   Failed                         taskrun/http-resolver-kz4pn-http-resolver                                 [User error] declared workspace "output" is required but has not been bound
arendelle-rn6gp              48s         Warning   InternalError                  taskrun/http-resolver-kz4pn-http-resolver                                 declared workspace "output" is required but has not been bound

and later on

default                      62s         Warning   FreeDiskSpaceFailed            node/kind-control-plane                                                   Failed to garbage collect required amount of images. Attempted to free 10449369497 bytes, but only found 3052318 bytes eligible to free.
default                      25m         Normal    Starting                       node/kind-worker                                                          Starting kubelet.
default                      25m         Warning   InvalidDiskCapacity            node/kind-worker                                                          invalid capacity 0 on image filesystem

@khrm
Copy link
Contributor

khrm commented Jul 16, 2025

Http resolver examples are failing.

@afrittoli
Copy link
Member

/retest

@afrittoli
Copy link
Member

/retest

@afrittoli
Copy link
Member

Now the http-resolver fails:

    examples_test.go:128: exit status 1 Output: Error from server (BadRequest): error when creating "STDIN": admission webhook "webhook.pipeline.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "value"

There was still a few references that makes the CI fail. This should
fix it.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Copy link
Member Author

It is finally green 🎉

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@tekton-robot tekton-robot merged commit 550b357 into tektoncd:main Jul 17, 2025
20 checks passed
@vdemeester vdemeester deleted the fix-e2e-rm-gcrio branch July 17, 2025 10:25
@vdemeester
Copy link
Member Author

This needs to be cherry-picked to old releases for the CI..

@vdemeester
Copy link
Member Author

/cherrypick release-v0.65.x

@vdemeester
Copy link
Member Author

/cherrypick release-v0.68.x

@vdemeester
Copy link
Member Author

/cherrypick release-v1.0.x

@vdemeester
Copy link
Member Author

/cherrypick release-v1.2.x

@tekton-robot
Copy link
Collaborator

@vdemeester: #8885 failed to apply on top of branch "release-v0.65.x":

Applying: Remove all reference to gcr.io tekton projects
Using index info to reconstruct a base tree...
M	config/300-crds/300-pipelinerun.yaml
M	config/300-crds/300-taskrun.yaml
M	pkg/apis/pipeline/v1/openapi_generated.go
M	pkg/apis/pipeline/v1/swagger.json
M	pkg/apis/pipeline/v1beta1/openapi_generated.go
M	pkg/apis/pipeline/v1beta1/swagger.json
M	tekton/release-pipeline.yaml
M	test/resolvers_test.go
M	test/tektonbundles_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/tektonbundles_test.go
Auto-merging test/resolvers_test.go
Auto-merging tekton/release-pipeline.yaml
Auto-merging pkg/apis/pipeline/v1beta1/swagger.json
Auto-merging pkg/apis/pipeline/v1beta1/openapi_generated.go
Auto-merging pkg/apis/pipeline/v1/swagger.json
Auto-merging pkg/apis/pipeline/v1/openapi_generated.go
Auto-merging config/300-crds/300-taskrun.yaml
CONFLICT (content): Merge conflict in config/300-crds/300-taskrun.yaml
Auto-merging config/300-crds/300-pipelinerun.yaml
CONFLICT (content): Merge conflict in config/300-crds/300-pipelinerun.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove all reference to gcr.io tekton projects
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v0.65.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@vdemeester: #8885 failed to apply on top of branch "release-v0.68.x":

Applying: Remove all reference to gcr.io tekton projects
Using index info to reconstruct a base tree...
M	config/300-crds/300-pipelinerun.yaml
M	config/300-crds/300-taskrun.yaml
M	pkg/apis/pipeline/v1/openapi_generated.go
M	pkg/apis/pipeline/v1/swagger.json
M	pkg/apis/pipeline/v1beta1/openapi_generated.go
M	pkg/apis/pipeline/v1beta1/swagger.json
M	tekton/release-pipeline.yaml
M	test/resolvers_test.go
M	test/tektonbundles_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/tektonbundles_test.go
Auto-merging test/resolvers_test.go
Auto-merging tekton/release-pipeline.yaml
Auto-merging pkg/apis/pipeline/v1beta1/swagger.json
Auto-merging pkg/apis/pipeline/v1beta1/openapi_generated.go
Auto-merging pkg/apis/pipeline/v1/swagger.json
Auto-merging pkg/apis/pipeline/v1/openapi_generated.go
Auto-merging config/300-crds/300-taskrun.yaml
CONFLICT (content): Merge conflict in config/300-crds/300-taskrun.yaml
Auto-merging config/300-crds/300-pipelinerun.yaml
CONFLICT (content): Merge conflict in config/300-crds/300-pipelinerun.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove all reference to gcr.io tekton projects
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v0.68.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #8918

In response to this:

/cherrypick release-v1.0.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #8919

In response to this:

/cherrypick release-v1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@waveywaves
Copy link
Member

/cherrypick release-v1.1.x

@tekton-robot
Copy link
Collaborator

@waveywaves: new pull request created: #8929

In response to this:

/cherrypick release-v1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants