-
Couldn't load subscription status.
- Fork 1.8k
Remove all reference to gcr.io tekton projects #8885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vdemeester: GitHub didn't allow me to request PR reviews from the following users: twoGiants. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approved.
|
/retest |
|
/kind cleanup |
849de30 to
ff031c0
Compare
16d43a7 to
ff00683
Compare
|
hmm. I don't understand the failures now… |
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vdemeester I think we need to fix step action. It refers to git-init catalog from gcr.
PS: I just saw that it was updated in catalog.
It is fixed on catalog now. |
ff00683 to
19edf77
Compare
|
ahhh I messed up the parameters… it should be green now 🙃 |
and later on |
|
Http resolver examples are failing. |
|
/retest |
|
/retest |
|
Now the http-resolver fails: |
55a1d27 to
85b9778
Compare
There was still a few references that makes the CI fail. This should fix it. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
85b9778 to
bdbe0a2
Compare
|
It is finally green 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This needs to be cherry-picked to old releases for the CI.. |
|
/cherrypick release-v0.65.x |
|
/cherrypick release-v0.68.x |
|
/cherrypick release-v1.0.x |
|
/cherrypick release-v1.2.x |
|
@vdemeester: #8885 failed to apply on top of branch "release-v0.65.x": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vdemeester: #8885 failed to apply on top of branch "release-v0.68.x": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vdemeester: new pull request created: #8918 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vdemeester: new pull request created: #8919 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-v1.1.x |
|
@waveywaves: new pull request created: #8929 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
There was still a few references that makes the CI fail. This should fix it.
/cc @afrittoli @twoGiants @waveywaves
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes