-
Couldn't load subscription status.
- Fork 1.8k
Remove all reference to gcr.io tekton projects #8885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,20 +16,28 @@ kind: PipelineRun | |
| metadata: | ||
| generateName: http-resolver- | ||
| spec: | ||
| workspaces: | ||
| - name: output | ||
| emptyDir: {} | ||
| pipelineSpec: | ||
| workspaces: | ||
| - name: output | ||
| tasks: | ||
| - name: http-resolver | ||
| taskRef: | ||
| resolver: http | ||
| params: | ||
| - name: url | ||
| value: https://api.hub.tekton.dev/v1/resource/tekton/task/tkn/0.4/raw | ||
| value: https://api.hub.tekton.dev/v1/resource/tekton/task/git-clone/0.10/raw | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be changed to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. But instead of changing this task, we should probably update the image there to ghcr and use artifacthub.io reference. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can do things in sequence. 0.10 already points to ghcr.io. And the hub api is still up. We will change this in a follow-up. Right now the idea is to get the CI green. |
||
| - name: http-username | ||
| value: git | ||
| - name: http-password-secret | ||
| value: my-secret | ||
| - name: http-password-secret-key | ||
| value: token | ||
| params: | ||
| - name: ARGS | ||
| value: ["version"] | ||
| - name: url | ||
| value: "https://github.com/kelseyhightower/nocode" | ||
| workspaces: | ||
| - name: output | ||
| workspace: output | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,14 +4,22 @@ kind: PipelineRun | |
| metadata: | ||
| generateName: http-resolver- | ||
| spec: | ||
| workspaces: | ||
| - name: output | ||
| emptyDir: {} | ||
| pipelineSpec: | ||
| workspaces: | ||
| - name: output | ||
| tasks: | ||
| - name: http-resolver | ||
| taskRef: | ||
| resolver: http | ||
| params: | ||
| - name: url | ||
| value: https://api.hub.tekton.dev/v1/resource/tekton/task/tkn/0.4/raw | ||
| value: https://api.hub.tekton.dev/v1/resource/tekton/task/git-clone/0.10/raw | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be changed to |
||
| params: | ||
| - name: ARGS | ||
| value: ["version"] | ||
| - name: url | ||
vdemeester marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| value: "https://github.com/kelseyhightower/nocode" | ||
| workspaces: | ||
| - name: output | ||
| workspace: output | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.