-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plant traits save as scalars #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 82.59% 80.59% -2.01%
==========================================
Files 13 13
Lines 678 706 +28
==========================================
+ Hits 560 569 +9
- Misses 118 137 +19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
talmo
approved these changes
Jul 5, 2023
eberrigan
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Update base_length_ratio results to scalar and return nan if length=0. * convert the data in scalar column to the value without []. * Modify stem width and base-related functions for rice traits. * change the argument name of 'lateral_only' to 'monocots'. * change the argument name of 'lateral_only' to 'monocots' (cont.). * modify functions to set nan values for base-related traits for rice. * Modify `get_base_median_ratio` function for all nans. * Modify `get_traits_value_plant_summary` for traits with no value []. --------- Co-authored-by: Lin Wang <linwang9926@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_base_length_ratio
: return base_length_ratio results as scalar and return Nan if length=0bases
,graphpipeline
,networklength
,points
, andscanline
, as well as test modulestest_graphpipeline
,test_points, test_scanline
,test_convhull
,test_ellipse
, andtest_networklength
. (fixes Modify traits for monocots (rice) #38 ).get_traits_value_plant_summary
: not trait.isna().all() to filter out the all nan non-scalar traits. Those summarized traits are all nans (fixes get_traits_value_plant_summary takes length of float object #39 ).