[make:crud] Rename add method of repository to save.
#1169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 1.0-dev branch.
Discussion
----------
Add `make:twig-component` maker
Adds a maker for `symfony/ux-twig-component`/`symfony/ux-live-component`.
**Creating a _standard_ twig component:**
```bash
bin/console make:twig-component
The name of your twig component (ie NotificationComponent):
> Notification
Make this a live component? (yes/no) [no]: # (defaults to yes if symfony/ux-live-component installed)
> no
created: src/Twig/Components/NotificationComponent.php
created: templates/components/notification.html.twig
Success!
```
```php
// src/Twig/Components/NotificationComponent.php
<?php
namespace App\Twig\Components;
use Symfony\UX\TwigComponent\Attribute\AsTwigComponent;
#[AsTwigComponent('notification')]
final class NotificationComponent
{
}
```
```twig
{# templates/components/notification.html.twig #}
<div{{ attributes }}>
<!-- component html -->
</div>
```
---
**Creating a _live_ twig component:**
```bash
bin/console make:twig-component --live # fails if symfony/ux-live-component is not installed
The name of your twig component (ie NotificationComponent):
> Notification
created: src/Twig/Components/NotificationComponent.php
created: templates/components/notification.html.twig
Success!
```
```php
// src/Twig/Components/NotificationComponent.php
<?php
namespace App\Twig\Components;
use Symfony\UX\LiveComponent\Attribute\AsLiveComponent;
use Symfony\UX\LiveComponent\DefaultActionTrait;
#[AsLiveComponent('notification')]
final class NotificationComponent
{
use DefaultActionTrait;
}
```
```twig
{# templates/components/notification.html.twig #}
<div{{ attributes }}>
<!-- component html -->
</div>
```
Ref: symfony/ux#108
Commits
-------
acde364 add make:twig-component maker
|
@bdaler I just merged in a few CI fixes, can you do a rebase please? |
jrushlow
requested changes
Sep 20, 2022
…o renameControllerMethod.1138
|
IMHO "add" is more consistent with the concept of collection, but I don't have anything against "save" |
|
The commit history looks a bit mashed up in this PR. Closing in favor of #1204 which contains cherry-picked changes from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addmethod of repository tosave