[ci] handle reset-password 8.1.10 version constraint #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
force-pushed
the
ci/reset-password
branch
3 times, most recently
from
8182e8e to
659cfac
Compare
jrushlow
force-pushed
the
ci/reset-password
branch
from
659cfac to
b1f1498
Compare
jrushlow
commented
Sep 20, 2022
weaverryan
reviewed
Sep 20, 2022
|
|
||
| if (\PHP_VERSION_ID > $this->blockedPhpVersionUpper) { | ||
| $isSupported = true; | ||
| } |
There was a problem hiding this comment.
This is what makes sense to me:
if ($hasPhpVersionConstraint && \PHP_VERSION_ID >= $this->blockedPhpVersionLower && \PHP_VERSION_ID <= $this->blockedPhpVersionUpper) {
return false;
}It says:
If the a blocked range of php versions was specified AND the current php version is inside of that range (greater than or equal to the lower and less than or equal to the upper), return false: the current php version is not supported.
bdaler
pushed a commit
to bdaler/maker-bundle
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.