[make:crud] use save instead of add repository methods #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
changed the title
jrushlow
changed the title
jrushlow
added
Related Tests Pass
Status: Needs Review
jrushlow
added
Status: Reviewed
This was referenced Sep 22, 2022
Closed
Merged
weaverryan
added a commit
that referenced
this pull request
Jul 10, 2023
…ories (mdoutreluingne, weaverryan) This PR was merged into the 1.0-dev branch. Discussion ---------- [WCM] Deleting `save` and `remove` methods from repositories Fix #1327 In this PR I've removed the `save` and `remove` methods from the repositories, for the reasons explained here #1327. ( The add method has been renamed to save, here #1204 ) Reviews welcome! Commits ------- 6d4c62c Removed unecessary use statement dff2f97 Fixing look up of Symfony version + removing incorrect renderForm() on 2x assertion methods c3b506d Fix use statement sort 027b9f5 Add WithCustomRepositoryLegacy.php to include the `renderForm()` version 1650332 Replacement renderForm() method deprecated by render() method e919b78 Adding EntityManagerInterface use statement if not already added bbb7967 Adding EntityManagerInterface use statement 5038082 Deleting `add` and `remove` methods from repositories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using an
add()method in the repository, it's been renamed tosave(). Logic behind the change is to not confuse with "add()" and item to a collection - we're "save()"ing an entity to persistence.Original work done by @bdaler in #1169
fixes #1138
fixes #788