Skip to content

Add ABI checking test for Distributed #63989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 1, 2023

We did once accidentally break ABI and it caused all kinds of trouble in undoing it since it was rather late.

We should have ABI testing, which this PR adds.

Resolves rdar://106067256

@ktoso
Copy link
Contributor Author

ktoso commented Mar 1, 2023

I prepared a digester dump using: ``

However struggle to figure out how to make sure the digester invocation sees the distributed module 🤔 I guess it is not in the dummy sdk, but how would I get it there or otherwise visible 🤔

/Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/swift-macosx-arm64/bin/swift-api-digester -target arm64-apple-macosx10.13 -diagnose-sdk -module Distributed -o /Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/swift-macosx-arm64/test-macosx-arm64/api-digester/Output/stability-distributed-abi.test.tmp.tmp/changes.txt -module-cache-path /Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/swift-macosx-arm64/test-macosx-arm64/api-digester/Output/stability-distributed-abi.test.tmp.tmp/module-cache -sdk /Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/swift-macosx-arm64/test-macosx-arm64/api-digester/Output/stability-distributed-abi.test.tmp.tmp/dummy.sdk -abi -avoid-location

<unknown>:0: warning: no such sysroot directory: '/Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/swift-macosx-arm64/test-macosx-arm64/api-digester/Output/stability-distributed-abi.test.tmp.tmp/dummy.sdk'
<unknown>:0: warning: using sysroot for 'dummy' but targeting 'MacOSX'
<unknown>:0: error: cannot load underlying module for 'Darwin'
Failed to load module: Distributed

Any hints welcome, thansk!

@ktoso ktoso requested a review from DougGregor March 1, 2023 04:53
@ktoso ktoso requested a review from nkcsgexi March 1, 2023 05:00
@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Mar 1, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Feb 27, 2024

Superseded by #71911

@ktoso ktoso closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant