[Distributed] whenLocal adoption of typed throws #71439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whenLocal is a "rethrows" and can be expressed using a typed throw now.
|
@swift-ci please smoke test |
DougGregor
reviewed
Feb 7, 2024
| ) async rethrows -> T? { | ||
| public nonisolated func whenLocal<T: Sendable, E>( | ||
| _ body: @Sendable (isolated Self) async throws(E) -> T | ||
| ) async throws(E) -> T? { |
There was a problem hiding this comment.
This is an ABI break. There's a little song-and-dance you can do to maintain ABI. See, e.g., #70971
There was a problem hiding this comment.
Thanks! Okey so the silgenname, thanks I’ll follow the same pattern 🙏
There was a problem hiding this comment.
I was trying to revive the effort to bring abi compat checking to Distributed but can't figure out how to dump the macos.json equivalent of Concurrency etc as we use in the digester tests 🤔
Meanwhile I fixed this signature: to $s11Distributed0A5ActorPAAE9whenLocalyqd__Sgqd__xYiYaYbKXEYaKs8SendableRd__lF which seems to be right.
822 sil [available 13.0] [ossa] @$s11Distributed0A5ActorPAAE9whenLocalyqd__Sgqd__xYiYaYbKXEYaKs8SendableRd__lF : $@convention(method) @async <Self where Self : DistributedActor><T where T : Sendable> (@guaranteed @noescape @Sendable @async @callee_guaranteed @substituted <τ_0_0, τ_0_1 where τ_0_0 : AnyObject> (@sil_isolated @guaranteed τ_0_0) -> (@out τ_0_1, @error any Error) for <Self, T>, @guaranteed Self) -> (@out Optional<T>, @error any Error) {
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whenLocal is a "rethrows" and can be expressed using a typed throw now.
resolves rdar://122464127