Enable Concurrency ABI verifier test on apple silicon #63987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
added
the
concurrency
ktoso
changed the title
|
@swift-ci please smoke test |
|
Relatedly, adding such test for Distributed so we don't have an accidental ABI break again #63989 |
nkcsgexi
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no good reason not to run this test on apple silicon macs; and by doing so, we make it easier to catch issues before submitting a CI test run.
It seems that the results are exactly the same on apple silicon so I did not have to create a separate baseline - works just fine. If I'm missing something let me know though.
Resolves rdar://106030660