[5.0] Overlays: Modernize hashing for Selector and CGFloat #21464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed versions `Selector.==` currently calls `sel_isEqual`, which is documented to be the same as == on the direct pointer values. We can safely replace the explicit implementation with the compiler-generated one. `Selector.hashValue` is deprecated as a Hashable requirement, and the preferred method to implement is `hash(into:)`. Implementing the proper function improves hashing performance by eliminating nested Hasher sessions. By removing the previous definition of `hashValue`, we allow the compiler to synthesize the correct `hash(into:)` (and `hashValue`) implementations. (cherry picked from commit 4e2dfb7)
This replaces the previously compiler-synthesized implementation with one that directly feeds the wrapped value to the hasher. The new definition is functionally equivalent, but warning-free and faster. (cherry picked from commit 7327d5d)
This makes for a small speedup, bringing CGFloat hashing to the same speed as direct Float/Double. (cherry picked from commit b58d3d1)
|
@swift-ci test |
lorentey
changed the title
|
Post-break ping. |
|
Hm, I suspect these have missed the boat for 5.0. The changes here aren't ABI-breaking, so we can easily defer them for later, along with the overlays' other hashValue definitions. ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-picked from #20872 and #20873)
These fix two low-hanging deprecation warnings (introduced by #21445) in the overlays.
Foundation still generates a bunch of these; however, these two are particularly easy to fix, and should lead to a nice speedup, so we should just do it.
rdar://problem/43394032