[CoreGraphics] CGFloat: Implement better hashing #20873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the previously compiler-synthesized implementation with one that directly feeds the wrapped value to the hasher. The new definition is functionally equivalent, but warning-free and faster.
This makes for a small speedup, bringing CGFloat hashing to the same speed as direct Float/Double.
|
@swift-ci test |
|
Build failed |
stephentyrone
approved these changes
Nov 29, 2018
|
Linux failure is unrelated -- re-running smoke tests for it. @swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR was originally part of #20685.)
SE-0206 deprecated
hashValueas aHashablerequirement, replacing it withhash(into:). This PR adds a direct implementation ofCGFloat.hash(into:)andCGFloat._rawHashValue(seed:), modernizing its hashing and bringing it to the same performance as that ofFloatandDouble.rdar://problem/43394032