[5.0][Sema] Emit a deprecation warning if a Hashable type only implements hashValue #21445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into:) isn’t SE-206 deprecated hashValue as a protocol requirement. We should gently encourage people to migrate to hash(into:), for its more secure, easier and faster hashing. Emit a compiler warning whenever hashValue has an explicit implementation, but hash(into:) doesn’t. (cherry picked from commit e0495a7)
(cherry picked from commit 1485404)
(cherry picked from commit cb3cff5)
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
Ah, my bad, this requires (at least some parts of) #20866 for the test suite. |
lorentey
force-pushed
the
actually-deprecate-hashValue-5.0
branch
from
fda620d to
ade8310
Compare
|
@swift-ci test |
airspeedswift
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-picked from #21057 and #20866)
SE-206 deprecated
hashValueas a protocol requirement. We should gently encourage people to migrate tohash(into:), for its more secure, easier and faster hashing.hashValuehas an explicit implementation, buthash(into:)doesn’t. ([Sema] Emit a deprecation warning if a Hashable type only implements hashValue #21057)rdar://problem/39838478, rdar://problem/46344811