[Sema] Emit a deprecation warning if a Hashable type only implements hashValue #21057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into:) isn’t SE-206 deprecated hashValue as a protocol requirement. We should gently encourage people to migrate to hash(into:), for its more secure, easier and faster hashing. Emit a compiler warning whenever hashValue has an explicit implementation, but hash(into:) doesn’t.
|
Build failed |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
You can't test two PRs from the same repo at the same time. (@millenomi just filed a request Radar to be able to do this, though.) |
|
cc @natecook1000 for the documentation changes. (We don't have a good way to deprecate protocol requirements, so we have to point out the deprecation in the docs instead.) |
|
@swift-ci test |
jrose-apple
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-206 deprecated
hashValueas a protocol requirement. We should gently encourage people to migrate tohash(into:), for its more secure, easier and faster hashing.Emit a compiler warning whenever
hashValuehas an explicit implementation, buthash(into:)doesn’t.rdar://problem/39838478
(This was originally part of #20685)