[Foundation] Update hashing for bridged NSError protocols #21056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
jrose-apple
approved these changes
Dec 7, 2018
DougGregor
approved these changes
Dec 10, 2018
Protocols in resilient libraries that wish to provide a default implementation of hashing need to do so by providing a hash(into:) implementation. hashValue has been deprecated as a Hashable requirement in SE-0206. Implementing only it in a protocol extension curses conforming types to get deprecation warnings by default.
…alue/_rawHashValue The compiler-synthesized / stdlib-provided default implementations seem perfectly fine for these.
…ntation These implementations did not produce the same hash values as the raw value. RawRepresentable provides a correct hashing implementation by default, so let’s just use that.
lorentey
force-pushed
the
error-hashing
branch
from
2f4709a to
23188af
Compare
|
Rebased to fix a conflict. I also added a commit that removes the (obsolete and slightly broken) hashValue implementations for |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocols that wish to provide a default implementation of hashing should do so by providing a
hash(into:)implementation.hashValuehas been deprecated as aHashablerequirement in SE-0206.Protocol extensions that only implement hashValue force
hashValue-based synthesis on conforming types by default, which will probably produce deprecation warnings soon.Add missing Hashable requirements to
_BridgedNSErrorand_BridgedStoredNSError.It is important to add these extensions now, since the presence/absence of defaulted Hashable requirements can cause ABI headaches down the road for conforming types, and these protocols are
used by ClangImporterinvolved in automatic conformance synthesis.rdar://problem/46496484