Add casting methods to protocols #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
ahoppen
force-pushed
the
as-protocol
branch
2 times, most recently
from
e7bac89 to
b58ae97
Compare
ahoppen
changed the title
|
@swift-ci Please test |
…ocol This allows us to use SyntaxProtocol as a return value again and provide nice functions that check if type-erased note conforms to a protocol.
|
swiftlang/swift-stress-tester#109 @swift-ci Please test |
This was referenced Nov 7, 2019
akyrtzi
reviewed
Nov 7, 2019
| @@ -13,7 +13,7 @@ | |||
| /// A Syntax node represents a tree of nodes with tokens at the leaves. | |||
| /// Each node has accessors for its known children, and allows efficient | |||
| /// iteration over the children through its `children` property. | |||
| public struct Syntax: SyntaxProtocol { | |||
| public struct Syntax: SyntaxProtocol, SyntaxHashable { | |||
There was a problem hiding this comment.
It's not clear to me, why is SyntaxHashable a separate protocol than SyntaxProtocol? Is there something that needs to conform to SyntaxProtocol but not SyntaxHashable or vice-versa?
There was a problem hiding this comment.
Hashable has a Self requirement and if we make SyntaxProtocol conform to Hashable, we cannot use it as a return type anymore.
akyrtzi
approved these changes
Nov 7, 2019
These return the non type-erased types of a node if it conforms to the given protocol and nil otherwise. With these methods returning the non type-erased type we can get rid of _asConcreteType.
|
Damn, had the wrong version of the swift repo checked out and generated outdated swiftlang/swift-stress-tester#109 |
|
Build failed |
This was referenced Nov 7, 2019
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Discard newlines when sorting imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These return the non type-erased types of a node if it conforms to the given protocol and
nilotherwise.With these methods returning the non type-erased type we can get rid of
_asConcreteType. The new way to get the concrete type of aSyntaxnode is to callas(SyntaxProtocol.self)which will return a non-type-erased type that conforms toSyntaxProtocol.