Validate a node's layout after it has been rewritten using the syntax rewriter #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
ahoppen
force-pushed
the
validate-syntax-layout
branch
from
04337ac to
e71fe57
Compare
This was referenced Nov 7, 2019
ahoppen
force-pushed
the
validate-syntax-layout
branch
from
e71fe57 to
8d347ae
Compare
ahoppen
changed the title
|
@swift-ci Please test |
ahoppen
force-pushed
the
validate-syntax-layout
branch
from
8d347ae to
097a252
Compare
harlanhaskins
approved these changes
Nov 7, 2019
|
@swift-ci Please test |
… rewriter Otherwise it is possible to generate invalid syntax trees using the syntax rewriter.
ahoppen
force-pushed
the
validate-syntax-layout
branch
from
097a252 to
ab8d0de
Compare
|
@swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Restrict doc-block to doc-line transform to first doc comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it is possible to generate invalid layouts using the
SyntaxRewriter. This PR makes it impossible to create invalid layouts in debug builds. Release builds have the validation disabled for performance reasons.