Remove isExpr etc. methods #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
remove-is-expr-etc
branch
from
cb7aab2 to
9cee7c5
Compare
The canonical way of checking this is to use is(ExprSyntaxProtocol.self)
ahoppen
force-pushed
the
remove-is-expr-etc
branch
from
9cee7c5 to
d8844b7
Compare
|
@swift-ci Please test |
harlanhaskins
approved these changes
Nov 7, 2019
akyrtzi
approved these changes
Nov 7, 2019
|
Build failed |
|
swiftlang/swift-stress-tester#110 @swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Remove calls to `FileHandle.synchronizeFile()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canonical way of checking if a syntax node is an expression is to use
is(ExprSyntaxProtocol.self), so we remove the unnecessary methods.We still need to keep the
isCollectionproperty sinceSyntaxCollectionis a protocol with associated type requirements and thus cannot be used as a return type.