Tests: Fix always succeeding XCTAssertAsyncNoThrow
#8026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autoclosure expression `{ throw error }` just creates a closure that
won't be executed. It leads to the test always succeeding even if the
`expression` throws an error.
kateinoigakukun
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci test |
|
@swift-ci test |
MaxDesiatov
approved these changes
Oct 7, 2024
|
@grynspan This assertion activation revealed that Is this intentional behavior or should we set the env variable regardless of the target platform? |
|
It has no effect on other platforms. We set it on macOS so that XCTest doesn't try to host Swift Testing from within Xcode, like it would if you were using Xcode instead of SwiftPM. It's a bit of an inelegant hack and we may remove it in a future Xcode update. |
`SWIFT_PM_TEST_LIBRARY` was renamed to `SWIFT_TESTING_ENABLED` in swiftlang#7789, but we forgot to update the test because `XCTAssertAsyncNoThrow` always succeeded and we didn't notice the failure.
kateinoigakukun
force-pushed
the
yt/assert-async-no-throw
branch
from
ab1e784 to
c50518d
Compare
|
Ok, then skip the test on non-macOS platforms |
|
@swift-ci test |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autoclosure expression
{ throw error }just creates a closure that won't be executed. It leads to the test always succeeding even if theexpressionthrows an error.Fortunately, I didn't find any issue to enable the assertion except for a single case (ab1e784)