Build one test product for both Swift Testing and XCTest (with Swift Testing enabled by default.) #7789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
build system
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/one-test-product-two-libraries-take-2
branch
from
58abe35 to
19a986d
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
…Testing enabled by default.) This PR refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time. On macOS, Xcode 16 is responsible for hosting Swift Testing content, so additional changes may be needed in Xcode to support this refactoring. Such changes are beyond the purview of the Swift open source project. This PR includes changes from the previous PRs numbered #7766, #7783, and #7787. Resolves rdar://120864035. --------- Co-authored-by: Pavel Yaskevich <xedin@apache.org>
grynspan
force-pushed
the
jgrynspan/one-test-product-two-libraries-take-2
branch
from
19a986d to
b667027
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
briancroom
reviewed
Jul 17, 2024
| @@ -177,7 +171,7 @@ enum TestingSupport { | |||
| // execution but is required when the tests are running in parallel as | |||
| // SwiftPM repeatedly invokes the test binary with the test case name as | |||
| // the filter. | |||
| let codecovProfile = buildParameters.buildPath.appending(components: "codecov", "default%m.profraw") | |||
| let codecovProfile = buildParameters.buildPath.appending(components: "codecov", "\(library)%m.profraw") | |||
There was a problem hiding this comment.
Can this use buildParameters.codeCovPath as the base?
There was a problem hiding this comment.
Presumably. This bit's not new though and I'd be tempting fate changing it in this PR. We can look at a change separately.
xedin
approved these changes
Jul 18, 2024
briancroom
approved these changes
Jul 18, 2024
grynspan
added a commit
that referenced
this pull request
Jul 18, 2024
…Testing enabled by default.) (#7789) This PR refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time. On macOS, Xcode 16 is responsible for hosting Swift Testing content, so additional changes may be needed in Xcode to support this refactoring. Such changes are beyond the purview of the Swift open source project. This PR includes changes from the previous PRs numbered #7766, #7783, Resolves rdar://120864035. Co-authored-by: Pavel Yaskevich <xedin@apache.org>
grynspan
added a commit
that referenced
this pull request
Jul 19, 2024
…Swift Testing enabled by default.) (#7794) **Explanation:** Refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time. **Scope:** Implementation of Swift Testing/SwiftPM integration; touches mostly `swift test` but affects `swift build` and `swift package init` as well. **Issue:** rdar://120864035 **Original PR:** #7777, #7789, #7796 **Risk:** Moderate—refactors how we build and run tests. **Testing:** Existing test coverage in the package as well as test coverage in the Swift Testing package; additional integration testing will be added once Swift Testing is in the toolchain. **Reviewer:** @bnbarham @xedin @briancroom @dennisweissmann --------- Co-authored-by: Pavel Yaskevich <xedin@apache.org>
This was referenced Jul 24, 2024
kateinoigakukun
added a commit
to kateinoigakukun/swift-package-manager
that referenced
this pull request
Oct 7, 2024
`SWIFT_PM_TEST_LIBRARY` was renamed to `SWIFT_TESTING_ENABLED` in swiftlang#7789, but we forgot to update the test because `XCTAssertAsyncNoThrow` always succeeded and we didn't notice the failure.
kateinoigakukun
added a commit
to kateinoigakukun/swift-package-manager
that referenced
this pull request
Oct 7, 2024
`SWIFT_PM_TEST_LIBRARY` was renamed to `SWIFT_TESTING_ENABLED` in swiftlang#7789, but we forgot to update the test because `XCTAssertAsyncNoThrow` always succeeded and we didn't notice the failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time.
On macOS, Xcode 16 is responsible for hosting Swift Testing content, so additional changes may be needed in Xcode to support this refactoring. Such changes are beyond the purview of the Swift open source project.
This PR includes changes from the previous PRs numbered #7766, #7783, #7784, and #7787.
Resolves rdar://120864035.