Tests: Fix test for SWIFT_TESTING_ENABLED environment variable

kateinoigakukun · kateinoigakukun · commit c50518dc6cb7 · 2024-10-07T20:25:31.000+09:00
`SWIFT_PM_TEST_LIBRARY` was renamed to `SWIFT_TESTING_ENABLED` in #7789, but we forgot to update the test because `XCTAssertAsyncNoThrow` always succeeded and we didn't notice the failure.
diff --git a/Fixtures/Miscellaneous/CheckTestLibraryEnvironmentVariable/Tests/CheckTestLibraryEnvironmentVariableTests/CheckTestLibraryEnvironmentVariableTests.swift b/Fixtures/Miscellaneous/CheckTestLibraryEnvironmentVariable/Tests/CheckTestLibraryEnvironmentVariableTests/CheckTestLibraryEnvironmentVariableTests.swift
@@ -2,7 +2,7 @@ import XCTest
 
 final class CheckTestLibraryEnvironmentVariableTests: XCTestCase {
     func testEnviromentVariable() throws {
-        let envvar = ProcessInfo.processInfo.environment["SWIFT_PM_TEST_LIBRARY"]
-        XCTAssertEqual(envvar, "XCTest")
+        let envvar = ProcessInfo.processInfo.environment["SWIFT_TESTING_ENABLED"]
+        XCTAssertEqual(envvar, "0")
     }
 }
diff --git a/Tests/CommandsTests/TestCommandTests.swift b/Tests/CommandsTests/TestCommandTests.swift
@@ -327,11 +327,14 @@ final class TestCommandTests: CommandsTestCase {
     }
 #endif
 
+#if os(macOS)
+    // "SWIFT_TESTING_ENABLED" is set only on macOS, skip the check on other platforms.
     func testLibraryEnvironmentVariable() async throws {
         try await fixture(name: "Miscellaneous/CheckTestLibraryEnvironmentVariable") { fixturePath in
             await XCTAssertAsyncNoThrow(try await SwiftPM.Test.execute(packagePath: fixturePath))
         }
     }
+#endif
 
     func testXCTestOnlyDoesNotLogAboutNoMatchingTests() async throws {
         try await fixture(name: "Miscellaneous/TestDiscovery/Simple") { fixturePath in

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import XCTest`
`2`	`2`
`3`	`3`	`final class CheckTestLibraryEnvironmentVariableTests: XCTestCase {`
`4`	`4`	`func testEnviromentVariable() throws {`
`5`		`- let envvar = ProcessInfo.processInfo.environment["SWIFT_PM_TEST_LIBRARY"]`
`6`		`- XCTAssertEqual(envvar, "XCTest")`
	`5`	`+ let envvar = ProcessInfo.processInfo.environment["SWIFT_TESTING_ENABLED"]`
	`6`	`+ XCTAssertEqual(envvar, "0")`
`7`	`7`	`}`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -327,11 +327,14 @@ final class TestCommandTests: CommandsTestCase {`
`327`	`327`	`}`
`328`	`328`	`#endif`
`329`	`329`
	`330`	`+#if os(macOS)`
	`331`	`+ // "SWIFT_TESTING_ENABLED" is set only on macOS, skip the check on other platforms.`
`330`	`332`	`func testLibraryEnvironmentVariable() async throws {`
`331`	`333`	`try await fixture(name: "Miscellaneous/CheckTestLibraryEnvironmentVariable") { fixturePath in`
`332`	`334`	`await XCTAssertAsyncNoThrow(try await SwiftPM.Test.execute(packagePath: fixturePath))`
`333`	`335`	`}`
`334`	`336`	`}`
	`337`	`+#endif`
`335`	`338`
`336`	`339`	`func testXCTestOnlyDoesNotLogAboutNoMatchingTests() async throws {`
`337`	`340`	`try await fixture(name: "Miscellaneous/TestDiscovery/Simple") { fixturePath in`