Repository navigation
fix: regenerate every route's types on sync - #17231
Open
Nic-Polumeyv wants to merge 3 commits into
Open
Nic-Polumeyv wants to merge 3 commits into
Nic-Polumeyv wants to merge 3 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/8e973e3114eb98ac235de3b2c26034c7b0c5168fOpen in |
🦋 Changeset detectedLatest commit: 8e973e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4 of 6 tasks
Rich-Harris
pushed a commit
that referenced
this pull request
Oct 1, 2026
alternative to #17231 cc: @Nic-Polumeyv closes #17224 re-opens #17095 This PR reverts the code and test changes from #17096 We should probably find a different fix for #17095 --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Nic-Polumeyv
force-pushed
the
write-types-always-regenerate
branch
from
October 1, 2026 16:50
1f6e05c to
8e973e3
Compare
5 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup in
write_all_typesdeletes the root types on every sync (src/routes/vssrc/routes), and they only come back because it also deletesroute_meta_data.json, which keeps the mtime skip off. When syncs overlap, another process can write the file in between, so the root is skipped and its types stay missing, or the file gets read half-written (#17095).This removes the skip and the meta file, and compares resolved paths in the cleanup.
Fixes #17095