Repository navigation
fix: refresh layout types when a page module changes - #17232
Open
Nic-Polumeyv wants to merge 2 commits into
Open
Nic-Polumeyv wants to merge 2 commits into
Nic-Polumeyv wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/dcf656658e2ecc4e01deaf357909dea501a4ca4dOpen in |
🦋 Changeset detectedLatest commit: dcf6566 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nic-Polumeyv
force-pushed
the
write-types-refresh-layouts
branch
from
September 26, 2026 18:05
5ab2186 to
93165d3
Compare
Nic-Polumeyv
force-pushed
the
write-types-always-regenerate
branch
from
October 1, 2026 16:50
1f6e05c to
8e973e3
Compare
Nic-Polumeyv
force-pushed
the
write-types-refresh-layouts
branch
from
October 1, 2026 16:58
90135bf to
dcf6566
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a page's
loadin dev only regenerates that page's types, but its parent layouts depend on it too: a layoutloadmay leave requiredApp.PageDatakeys to the pages only while every page below it has aload. Until the next full sync the layout keeps the old rule.write_typesnow refreshes the ancestor layouts when a page'sloadexport appears or disappears. Proxies are cached by file content across syncs, which is what makes both the check and the refresh cheap.Stacked on #17231.