Skip to content

test: verify dependencies are externalised - #17069

Merged
elliott-with-the-longest-name-on-github merged 5 commits into
version-3from
teemingc-test-adapter-node-external-dependency
Sep 9, 2026
Merged

test: verify dependencies are externalised#17069
elliott-with-the-longest-name-on-github merged 5 commits into
version-3from
teemingc-test-adapter-node-external-dependency

Conversation

@teemingc

@teemingc teemingc commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Adds regression coverage for adapter-node's production dependency externalization. The platform app now consumes a local fixture dependency at runtime and verifies its implementation is absent from the generated JavaScript.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@teemingc
test: verify adapter-node externalizes dependencies
feba543 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 0f84abd:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/0f84abd08b86623da57c0c7abf1cf357b12bdca0

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17069

@changeset-bot

changeset-bot Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0f84abd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

svelte-docs-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-17069-svelte.vercel.app/

@teemingc
test: move adapter-node build assertion to vitest
7c7bf0d 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc
test: build adapter-node before app tests
0fb6e41 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc teemingc mentioned this pull request Sep 9, 2026
Merged
5 of 6 tasks
@teemingc teemingc changed the title test: verify adapter-node externalizes dependencies test: verify dependencies are externalised Sep 9, 2026
@teemingc teemingc mentioned this pull request Sep 9, 2026
Merged
3 of 6 tasks
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github merged commit 816e064 into version-3 Sep 9, 2026
41 checks passed
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github deleted the teemingc-test-adapter-node-external-dependency branch September 9, 2026 21:48
elliott-with-the-longest-name-on-github added a commit that referenced this pull request Sep 9, 2026
@teemingc @elliott-with-the-longest-name-on-github
test: verify handler is exported (#17077)
d05c60a 
stacked on #17069

Adds two tests:
- checks that `handler` is exported from `build/handler.js`
- ensures user module IDs aren't replaced by us during the build

Co-authored-by: Elliott Johnson <hello@ell.iott.dev>
This was referenced Sep 25, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees

No one assigned

Labels

pkg:adapter-node

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teemingc @elliott-with-the-longest-name-on-github