Skip to content

test: verify handler is exported - #17077

Merged
elliott-with-the-longest-name-on-github merged 14 commits into
version-3from
teemingc-adapter-regression-tests-version-3
Sep 9, 2026
Merged

test: verify handler is exported#17077
elliott-with-the-longest-name-on-github merged 14 commits into
version-3from
teemingc-adapter-regression-tests-version-3

Conversation

@teemingc

@teemingc teemingc commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

stacked on #17069

Adds two tests:

  • checks that handler is exported from build/handler.js
  • ensures user module IDs aren't replaced by us during the build

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

teemingc and others added 5 commits September 9, 2026 01:51
@teemingc
test: verify adapter-node externalizes dependencies
feba543 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc
test: move adapter-node build assertion to vitest
7c7bf0d 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc
test: build adapter-node before app tests
0fb6e41 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc
Merge branch 'version-3' into teemingc-test-adapter-node-external-dep…
1e030f7 
…endency
@teemingc
test: add adapter bundling regressions
82209a6 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from ec87d94:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/ec87d9410d53d25defd30a47ed68d44781ddf1c6

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17077

@changeset-bot

changeset-bot Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ec87d94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teemingc
teemingc changed the base branch from main to version-3 September 9, 2026 14:15
@svelte-docs-bot

svelte-docs-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-17077-svelte.vercel.app/

teemingc and others added 4 commits September 9, 2026 22:17
@teemingc
test: verify handler export
ac2b13c 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc
Merge branch 'teemingc-test-adapter-node-external-dependency' into te…
0a4125a 
…emingc-adapter-regression-tests-version-3
@teemingc
test: run handler assertion with vitest
4fae40d 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc
test: restore stubbed handler environment
6255d21 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@teemingc teemingc added pkg:adapter-node needs-platform-tests This PR needs to run platform tests in order to merge. labels Sep 9, 2026
@teemingc teemingc changed the title test: add adapter bundling regressions test: verify handler is exported Sep 9, 2026
@teemingc teemingc mentioned this pull request Sep 9, 2026
Merged
5 of 6 tasks
@teemingc
teemingc changed the base branch from version-3 to teemingc-test-adapter-node-external-dependency September 9, 2026 15:11
@svelte-triage-bot svelte-triage-bot Bot mentioned this pull request Sep 9, 2026
Merged
1 of 6 tasks
Base automatically changed from teemingc-test-adapter-node-external-dependency to version-3 September 9, 2026 21:48
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github merged commit d05c60a into version-3 Sep 9, 2026
41 checks passed
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github deleted the teemingc-adapter-regression-tests-version-3 branch September 9, 2026 22:21
elliott-with-the-longest-name-on-github pushed a commit that referenced this pull request Sep 9, 2026
@teemingc
chore: avoid double-bundling (#17068)
03f7b48 
stacked on top of #17077

This PR gets rid of the second bundle step in the Node adapter in favour
of configuring the Vite build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees

No one assigned

Labels

needs-platform-tests This PR needs to run platform tests in order to merge. pkg:adapter-node

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teemingc @elliott-with-the-longest-name-on-github