improv: Add the ability to pass a custom footer to specific components #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: switch to mock provider (#866) * test: switch most thirdparty test to use mock provider * test: fix test errors * chore: bump version to allow devTag * adding dev-v0.48.1 tag to this commit to ensure building * test: stability fixes for python e2e tests * adding dev-v0.48.1 tag to this commit to ensure building * test: stability fixes for python e2e tests * adding dev-v0.48.1 tag to this commit to ensure building * test: python stability fixes * adding dev-v0.48.1 tag to this commit to ensure building * test: python stability fixes * adding dev-v0.48.1 tag to this commit to ensure building * ci: Update tests to support running with circle CI tests (#867) * Update tests to support running with circle CI tests * Allow the current branch to run to test the pipeline * Allow the build step to run in pipeline for tests to run properly * Make markTest not run on test branches * Undo changes to not run the test again --------- Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech> * Add init setup for webauthn recipe * Define recipe methods to make them override-able * Add component override definition * Add definition of prebuiltui * Add more changes for supporting feature components * Add some fixes for webauthn * Undo a change for made for testing * Add fix for making continue with passkey component show up * Update the continue with passwordless button text * Update the play details for signup with passkey * Add some fixes for the webauthn sign up /in functionality * Add support for passing isSignUp as a property in preload checks function * Add support for a proper sign up theme component * Add init support for using FormBase for rendering the sign up form * Add more fixes for properly rendering the full page passkey page * Add support for reusing auth style components in webauthn full pages * Add support for recover account button in sign up for webauthn * Add support for continue without passkey link below continue button * Make continue button uppercase for webauthn signup * Make resetFactorList a supported prop for component props * Add fixes for making the sign up component buttons work properly * Make continue without passkey a separate component * Make the form on submit function re-usable * Add support for rendering the confirmation view in sign up for passkey * Add support for showing the continue with part in the intermediate step * Add support for passkey feature blocks * Finish the UI implementation of the passkey confirmation component * Add updated callAPI functions for signup * Add support for handling recoverable errors in the UI * Add support for handling all scenarios of signup flow * Add support for sign in functionality * Refactor the code to create SignInTheme * Add fixes for making sign in work properly for passkey * Add support for Recover Account form component in webauthn * Fix the width of sub header for account recovery form * Add support for sending recovery email for webauthn * Add init support for a recovery using token feature * Add support for rendering passkey link form * Add fixes for properly showing the create a passkey form in token recovery screen * Add support for parsing email to be read from query in recovery flow * Add support for account recovery success screen * Add support for redirecting to sign in page on recovery success * Add support for getting register options on load * Add support for handling fetch errors while recovery registration options fetch * Add support for showing caution on signup page for email * Update stories/allrecipes.stories.tsx Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech> * Update lib/ts/recipe/webauthn/components/themes/translations.ts Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech> * Update lib/ts/recipe/webauthn/components/themes/signUp/recoverAccountForm.tsx Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech> * Update lib/ts/recipe/webauthn/components/themes/signUp/recoverAccountForm.tsx Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech> * Add some fixes for requested changes * Add a merge fix * Refactor formBase functions to use handleCallAPI * Move svg components to assets directory * Move more svg components to assets * Add more fixes based on requested changes * Use CSS variables for re-usable colors * Add fixes for passkey feature blocks not rendering * Fix build issues * Add init changes to refactor recover account email to be a separate feature * Add support for recovery email being a separate route on its own * Add support for properly redirecting on recover account click * Add support for considering the expiresAt field while recovering account * Add basic tests, mocks and helpers for webauthn signup * Add webauthn mock with testContext and more tests * Add more signup tests for webauthn * Add support for not requiring email for sign in * Add mocks for webauthn sign in and in react 16 examples * Add init tests for sign in for webauthn * Add test for checking general error on sign in * Add support for proper e2e testing for the sign in functionality of passkey * Add recovery email related helpers and init test * Add tests for various scenarios for email recovery * Add more tests for recovery email sending flow * Add proper e2e tests for signup * Add support for handling recovery token flow * Add support for testing sending recovery token properly * Add test for checking recovery with token * Add test to test recovery of account using token * Add test for checking invalid recovery token * Add support for testing register options throwing error for recovery with token * Add tests and cleanup for recovery with token * Add fix based on updated web-js method types * Add support for showing error on invalid credentials on signin attempt * Add fix for handling invalid credentials error properly * Add support for handling email already exists in signup * Add test for checking existing user sign up flow * Add support for handling invalid options error * Add support for showing error indicating passkey is not supported * Add tests for checking passkey not supported in UI * Add test for invalid options error showing an UI error in signin * Add init support for showing passkey not supported in browser * Add support for showing passkey not supported in recover flow * Add support for not allowing email to be empty in signup * Add test for checking whether email exists or not * Add tests for checking passkey not supported by browser * Add support for hiding back button if only one recipe is enabled in webauthn * Add some component fixes for the original factor IDs being passed * Add test for checking back button not shown if only one recipe is enabled * Add support for rendering icon in buttons and use it for passkey * Update lib/ts/recipe/webauthn/functionOverrides.ts Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech> * Bump react types to 18 and add type fixes according to react 18 changes * Add changes based on PR review * Optimize something went wrong icon * Update override-able function defs based on web-js changes * Update user input for sign in and up and recovery * Fix tests for recovery token flow * Add fixes for all webauthn tests * Add fix for injecting crypto in webauthn test script for server * Change version of web-js to point to webauthn branch * Add changes based on PR review * Bump changelog and some test related fixes * Add fixes to make all webauthn tests pass after changes * Add fixes for tests to use the correct server URL for token * Update recovery tests for webauthn to not check token length * Add only to run only webauthn recovery related tests * Revert "Add only to run only webauthn recovery related tests" This reverts commit 7550642. * Replace RecoverableError with GeneralError * Get rid of originalFactorIds and use showBackButton instead * feat(webauthn): PR review and minor cleanup * chore: update date in changelog --------- Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>
* fix: Include missing webauthn type * chore: bump version and add changelog --------- Co-authored-by: Mihaly Lengyel <mihaly@lengyel.tech>
The change is required by the captcha plugin in order to have a place to render the captcha input.
|
✅ No documentation updates required. |
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes add a
footerproperty to specific components. This is required by the captcha plugin in order to render the captcha input at the end of the form.