Skip to content

fix: Webauthn test updates due to changes #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

deepjyoti30-st
Copy link
Contributor

Summary of change

This PR updates webauthn tests to make them pass based on the updated code changes for showBackButton and general error component usage.

Related issues

Test Plan

All Webauthn tests should pass

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Remaining TODOs for this PR

Copy link

size-limit report 📦

Path Size
lib/build/index.js 24.83 KB (0%)
recipe/session/index.js 25.53 KB (0%)
recipe/session/prebuiltui.js 30.33 KB (0%)
recipe/thirdparty/index.js 32.5 KB (0%)
recipe/emailpassword/index.js 11.92 KB (0%)
recipe/emailverification/index.js 8.17 KB (0%)
recipe/passwordless/index.js 15.77 KB (0%)
recipe/emailverification/prebuiltui.js 35.08 KB (0%)
recipe/thirdparty/prebuiltui.js 54.28 KB (0%)
recipe/emailpassword/prebuiltui.js 41.29 KB (0%)
recipe/passwordless/prebuiltui.js 129.41 KB (0%)
recipe/multitenancy/index.js 7.02 KB (0%)
recipe/multifactorauth/index.js 11.79 KB (0%)
recipe/multifactorauth/prebuiltui.js 34.01 KB (0%)
recipe/oauth2provider/index.js 7.78 KB (0%)
recipe/oauth2provider/prebuiltui.js 32.44 KB (0%)
recipe/webauthn/index.js 10.74 KB (0%)
recipe/webauthn/prebuiltui.js 58.62 KB (-0.01% 🔽)

@porcellus porcellus merged commit 281f8a0 into 0.49 Mar 20, 2025
3 of 27 checks passed
@porcellus porcellus deleted the fix/webauthn-test-updates-due-to-changes branch March 20, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants