-
Notifications
You must be signed in to change notification settings - Fork 94
feat: Webauthn support #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: switch most thirdparty test to use mock provider * test: fix test errors
* Update tests to support running with circle CI tests * Allow the current branch to run to test the pipeline * Allow the build step to run in pipeline for tests to run properly * Make markTest not run on test branches * Undo changes to not run the test again --------- Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>
…ns/supertokens-auth-react into feat/webauthn/base
size-limit report 📦
|
porcellus
reviewed
Mar 11, 2025
lib/ts/recipe/authRecipe/components/feature/authPage/authPage.tsx
Outdated
Show resolved
Hide resolved
porcellus
requested changes
Mar 11, 2025
lib/ts/recipe/webauthn/components/features/recoverAccountWithToken/index.tsx
Outdated
Show resolved
Hide resolved
lib/ts/recipe/webauthn/components/themes/signUp/confirmation.tsx
Outdated
Show resolved
Hide resolved
lib/ts/recipe/webauthn/components/themes/recoverAccountWithToken/index.tsx
Show resolved
Hide resolved
This reverts commit 7550642.
deepjyoti30-st
commented
Mar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving replies
porcellus
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR adds webauthn support including pre-builtUI.
Related issues
Test Plan
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.someFunc: function () {..}
).size-limit
section ofpackage.json
with the size limit set to the current size rounded up.rollup.config.mjs
lib/ts/types.ts
lib/ts/recipe/multifactorauth/types.ts