starknet_os: add messages load_into to the aggregator load output hint

[TzahiTaub]

No description provided.

[reviewable-StarkWare]

This change is 

[TzahiTaub]

• starknet_os: complete aggregator load os output hint impl #8353
• starknet_os: add write_classes_changes impl for the aggregator os output loading #8352
• starknet_os: add write_contract_changes impl+StateEntryManager to the aggregator_utils #8351
• starknet_os: define LoadCairoObjectStateless and impl for L1-L2 messages #8350
• starknet_os: add messages load_into to the aggregator load output hint #8266 👈 (View in Graphite)
• starknet_os: initial impl of the aggregator get_os_output hint #8246
• starknet_os: remove DeprecatedOsStateDiff #8230
• starknet_os: replace as_state_maps of DeprecatedOsSTateDiff with Full and Partial #8229
• starknet_os: replace CompiledClassHashUpdate with full and partial structs #8228
• starknet_os: move contract changes methods to os_output_types #8227
• starknet_os: replace ContractChanges with Full or Partial structs #8226
• starknet_os: replace ContractStorageUpdate with new full or partial structs #8225
• starknet_os: add os_output_types #8224
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

---

crates/starknet_os/src/hints/hint_implementation/aggregator_utils.rs line 17 at r1 (raw file):

pub(crate) trait ToMaybeRelocatables {
    fn to_maybe_relocatables(&self) -> Vec<MaybeRelocatable>;
}

a bit too general... no?
or will you implement this for other types?

Suggestion:

pub(crate) trait FlattenMessage {
    fn flatten(&self) -> Vec<MaybeRelocatable>;
}

---

crates/starknet_os/src/hints/hint_implementation/aggregator_utils.rs line 45 at r1 (raw file):

        res
    }
}

where can i see how messages are flattened originally? on the py side?

Code quote:

impl ToMaybeRelocatables for MessageToL1 {
    fn to_maybe_relocatables(&self) -> Vec<MaybeRelocatable> {
        let mut res = Vec::<MaybeRelocatable>::with_capacity(
            MESSAGE_TO_L1_CONST_FIELD_SIZE + self.payload.0.len(),
        );
        res.push(Felt::from(self.from_address).into());
        res.push(Felt::from(self.to_address).into());
        res.push(Felt::from(self.payload.0.len()).into());
        res.extend(self.payload.0.iter().map(|felt| felt.into()));
        res
    }
}

impl ToMaybeRelocatables for MessageToL2 {
    fn to_maybe_relocatables(&self) -> Vec<MaybeRelocatable> {
        let mut res = Vec::<MaybeRelocatable>::with_capacity(
            MESSAGE_TO_L2_CONST_FIELD_SIZE + self.payload.0.len(),
        );
        res.push(Felt::from(self.from_address).into());
        res.push(Felt::from(self.to_address).into());
        res.push((self.nonce.0).into());
        res.push((self.selector.0).into());
        res.push(Felt::from(self.payload.0.len()).into());
        res.extend(self.payload.0.iter().map(|felt| felt.into()));
        res
    }
}

[TzahiTaub]

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/starknet_os/src/hints/hint_implementation/aggregator_utils.rs line 17 at r1 (raw file):

Previously, dorimedini-starkware wrote…

a bit too general... no?
or will you implement this for other types?

Yes, will implement for other types. See here

---

crates/starknet_os/src/hints/hint_implementation/aggregator_utils.rs line 45 at r1 (raw file):

Previously, dorimedini-starkware wrote…

where can i see how messages are flattened originally? on the py side?

L1 + similar code in the deprecated syscalls.
L2

[dorimedini-starkware]

Reviewed 1 of 3 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[dorimedini-starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[graphite-app]

Merge activity

• Aug 6, 8:38 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)