Skip to content

starknet_os: move contract changes methods to os_output_types #8227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TzahiTaub
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@TzahiTaub TzahiTaub force-pushed the 07-27-starknet_os_move_contract_changes_methods_to_os_output_types branch from daf5e32 to 5254763 Compare July 28, 2025 08:27
@TzahiTaub TzahiTaub force-pushed the 07-27-starknet_os_replace_contractchanges_with_full_or_partial_structs branch from 444505a to 7a0e9aa Compare July 28, 2025 08:27
@TzahiTaub TzahiTaub force-pushed the 07-27-starknet_os_move_contract_changes_methods_to_os_output_types branch from 5254763 to 4033d55 Compare July 28, 2025 09:14
@TzahiTaub TzahiTaub force-pushed the 07-27-starknet_os_replace_contractchanges_with_full_or_partial_structs branch from 7a0e9aa to 5aa572b Compare July 28, 2025 09:14
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@TzahiTaub TzahiTaub force-pushed the 07-27-starknet_os_move_contract_changes_methods_to_os_output_types branch from 4033d55 to e67d6e1 Compare July 28, 2025 10:53
@TzahiTaub TzahiTaub force-pushed the 07-27-starknet_os_replace_contractchanges_with_full_or_partial_structs branch from 5aa572b to 9e6cb12 Compare July 28, 2025 10:53
@graphite-app graphite-app bot changed the base branch from 07-27-starknet_os_replace_contractchanges_with_full_or_partial_structs to graphite-base/8227 July 28, 2025 12:35
@TzahiTaub TzahiTaub force-pushed the 07-27-starknet_os_move_contract_changes_methods_to_os_output_types branch from e67d6e1 to 90b30c8 Compare July 28, 2025 13:14
@TzahiTaub TzahiTaub force-pushed the graphite-base/8227 branch from 9e6cb12 to f1ba3da Compare July 28, 2025 13:14
@graphite-app graphite-app bot changed the base branch from graphite-base/8227 to main-v0.14.0 July 28, 2025 13:14
Copy link

graphite-app bot commented Jul 28, 2025

Merge activity

  • Jul 28, 1:14 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Merged via the queue into main-v0.14.0 with commit 75382e0 Jul 28, 2025
16 of 33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants