starknet_os: replace ContractStorageUpdate with new full or partial structs

[TzahiTaub]

No description provided.

[reviewable-StarkWare]

This change is 

[TzahiTaub]

• starknet_os: complete aggregator load os output hint impl #8353
• starknet_os: add write_classes_changes impl for the aggregator os output loading #8352
• starknet_os: add write_contract_changes impl+StateEntryManager to the aggregator_utils #8351
• starknet_os: define LoadCairoObjectStateless and impl for L1-L2 messages #8350
• starknet_os: add messages load_into to the aggregator load output hint #8266
• starknet_os: initial impl of the aggregator get_os_output hint #8246
• starknet_os: remove DeprecatedOsStateDiff #8230
• starknet_os: replace as_state_maps of DeprecatedOsSTateDiff with Full and Partial #8229
• starknet_os: replace CompiledClassHashUpdate with full and partial structs #8228
• starknet_os: move contract changes methods to os_output_types #8227
• starknet_os: replace ContractChanges with Full or Partial structs #8226
• starknet_os: replace ContractStorageUpdate with new full or partial structs #8225 👈 (View in Graphite)
• starknet_os: add os_output_types #8224
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @TzahiTaub)

---

crates/starknet_os/src/io/os_output_types.rs line 43 at r1 (raw file):

            key: wrap_missing_as(iter.next(), "storage key")?,
            new_value: wrap_missing(iter.next(), "storage value")?,
        })

where is this used?

Code quote:

        Ok(Self {
            key: wrap_missing_as(iter.next(), "storage key")?,
            new_value: wrap_missing(iter.next(), "storage value")?,
        })

---

crates/starknet_os/src/io/os_output.rs line 149 at r1 (raw file):

#[cfg_attr(feature = "deserialize", derive(serde::Deserialize, serde::Serialize))]
#[derive(Debug, PartialEq)]
/// Represents the changes in a contract instance.

Suggestion:

/// Represents the changes in a contract instance, in full output mode (prev values included).

---

crates/starknet_os/src/io/os_output.rs line 219 at r1 (raw file):

            new_class_hash,
            // Should be similar to the full_output code,only with partial updates.
            storage_changes: vec![],

what's this? where did the partial output go?
this struct also expects full-output only, how can you even get here?

storage_changes: Vec<FullContractStorageUpdate>,

Code quote:

            // Should be similar to the full_output code,only with partial updates.
            storage_changes: vec![],

[TzahiTaub]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/starknet_os/src/io/os_output.rs line 219 at r1 (raw file):

Previously, dorimedini-starkware wrote…

what's this? where did the partial output go?
this struct also expects full-output only, how can you even get here?

storage_changes: Vec<FullContractStorageUpdate>,

This is the struct I'm killing slowly. I handle the full output case properly because it is used in crates/starknet_os/src/hints/hint_implementation/stateful_compression/tests.rs . It is deleted in the following PR and replaced with the right implementation.

---

crates/starknet_os/src/io/os_output_types.rs line 43 at r1 (raw file):

Previously, dorimedini-starkware wrote…

where is this used?

In the next PR

---

crates/starknet_os/src/io/os_output.rs line 149 at r1 (raw file):

#[cfg_attr(feature = "deserialize", derive(serde::Deserialize, serde::Serialize))]
#[derive(Debug, PartialEq)]
/// Represents the changes in a contract instance.

Nope, this struct is the one that goes to trash - it doesn't have the distinction (it covers both "with no prev" and "with prev").

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[dorimedini-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[graphite-app]

Merge activity

• Jul 28, 12:09 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.