fix(starknet_l1_provider): don't override unnecessarily, use real flow #5291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Mar 26, 2025
This was referenced Mar 26, 2025
elintul
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
branch
from
8803d3f to
a3f56c5
Compare
giladchase
force-pushed
the
gilad/03-26-fix_starknet_l1_provider_don_t_override_unnecessarily_use_real_flow
branch
from
8fecbe9 to
83b0dda
Compare
elintul
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
branch
from
a3f56c5 to
7dce2a0
Compare
giladchase
force-pushed
the
gilad/03-26-fix_starknet_l1_provider_don_t_override_unnecessarily_use_real_flow
branch
from
83b0dda to
4eccae1
Compare
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
branch
from
7dce2a0 to
3e200b1
Compare
giladchase
force-pushed
the
gilad/03-26-fix_starknet_l1_provider_don_t_override_unnecessarily_use_real_flow
branch
from
4eccae1 to
213eb69
Compare
elintul
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
giladchase
force-pushed
the
gilad/03-26-fix_starknet_l1_provider_don_t_override_unnecessarily_use_real_flow
branch
from
213eb69 to
aa5314e
Compare
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
branch
from
3e200b1 to
3afd5b8
Compare
giladchase
changed the base branch from
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
to
main
giladchase
force-pushed
the
gilad/03-26-fix_starknet_l1_provider_don_t_override_unnecessarily_use_real_flow
branch
from
aa5314e to
43aaea0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.