chore(starknet_l1_provider): not related to mempool #5290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Mar 26, 2025
elintul
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
branch
from
8803d3f to
a3f56c5
Compare
giladchase
force-pushed
the
gilad/03-26-refactor_starknet_l1_provider_use_consts
branch
from
7083c46 to
ecd351e
Compare
elintul
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
giladchase
force-pushed
the
gilad/03-26-refactor_starknet_l1_provider_use_consts
branch
from
ecd351e to
d4da472
Compare
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
branch
from
a3f56c5 to
7dce2a0
Compare
giladchase
force-pushed
the
gilad/03-26-refactor_starknet_l1_provider_use_consts
branch
from
d4da472 to
da587a1
Compare
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
branch
from
7dce2a0 to
3e200b1
Compare
elintul
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Makes it easier to debug (tooltips show the value)
giladchase
force-pushed
the
gilad/03-26-refactor_starknet_l1_provider_use_consts
branch
from
da587a1 to
689c7a1
Compare
Right now we're duplicating this util, until we decide on a central super-lean crate for sharing common stuff
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_not_related_to_mempool
branch
from
3e200b1 to
3afd5b8
Compare
giladchase
changed the base branch from
gilad/03-26-refactor_starknet_l1_provider_use_consts
to
main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're duplicating this util, until we decide on a central
super-lean crate for sharing common stuff