chore(starknet_l1_provider): move flow test into unit test #5288
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_move_flow_test_into_unit_test
branch
from
ad2d735 to
2bb9170
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_move_flow_test_into_unit_test
branch
from
2bb9170 to
3522af7
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Merge activity
|
There was a problem hiding this comment.
Reviewable status:
Looks like our test runner doesn't support running integration tests that depend on the crate with `testing` feature, so we can only use integration tests that don't need `testing` on the same crate :( This is almost all a MOVE with only one required change: the bootstrap_e2e has gone stale and is broken, so i added an `ignore`. The reason is that it wasn't run in the CI since required-features doesn't add features, it just doesn't run the test if the feature isn't there :/ Will fix the test in an upcoming PR.
giladchase
force-pushed
the
gilad/03-26-chore_starknet_l1_provider_move_flow_test_into_unit_test
branch
from
3522af7 to
f674281
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
Looks like our test runner doesn't support running integration tests that depend on the crate with `testing` feature, so we can only use integration tests that don't need `testing` on the same crate :( This is almost all a MOVE with only one required change: the bootstrap_e2e has gone stale and is broken, so i added an `ignore`. The reason is that it wasn't run in the CI since required-features doesn't add features, it just doesn't run the test if the feature isn't there :/ Will fix the test in an upcoming PR. Co-authored-by: Gilad Chase <gilad@starkware.com>
Looks like our test runner doesn't support running integration tests
that depend on the crate with
testingfeature, so we can only useintegration tests that don't need
testingon the same crate :(This is almost all a MOVE with only one required change: the
bootstrap_e2e has gone stale and is broken, so i added an
ignore.The reason is that it wasn't run in the CI since required-features
doesn't add features, it just doesn't run the test if the feature isn't
there :/
Will fix the test in an upcoming PR.