Skip to content

chore(starknet_sequencer_node): service name to service fn #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Mar 18, 2025

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.494 ms 34.524 ms 34.554 ms]
change: [-4.3489% -2.6854% -1.2279%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion


crates/starknet_sequencer_node/src/deployment.rs line 141 at r1 (raw file):

        match self {
            DistributedNodeServiceName::Batcher => Service::new(
                ServiceName::ConsolidatedNode(ConsolidatedNodeServiceName::Node),

Did you mean DistributedNode(DistributedNodeServiceName::Batcher?

Code quote:

ConsolidatedNode(ConsolidatedNodeServiceName::Node)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from 03-18-chore_starknet_sequencer_node_format_deployment_variants to graphite-base/5013 March 18, 2025 13:15
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_service_name_to_service_fn branch from 798d709 to a5e5434 Compare March 18, 2025 13:15
@graphite-app graphite-app bot changed the base branch from graphite-base/5013 to main March 18, 2025 13:16
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_service_name_to_service_fn branch from a5e5434 to 0789a77 Compare March 18, 2025 13:16
Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor Author

Itay-Tsabary-Starkware commented Mar 18, 2025

Merge activity

  • Mar 18, 12:00 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 18, 12:00 PM EDT: A user added this pull request to the GitHub merge queue with Graphite.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit de86965 Mar 18, 2025
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants