-
Notifications
You must be signed in to change notification settings - Fork 52
chore(starknet_sequencer_node): service name to service fn #5013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_sequencer_node): service name to service fn #5013
Conversation
Artifacts upload workflows: |
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion
crates/starknet_sequencer_node/src/deployment.rs
line 141 at r1 (raw file):
match self { DistributedNodeServiceName::Batcher => Service::new( ServiceName::ConsolidatedNode(ConsolidatedNodeServiceName::Node),
Did you mean DistributedNode(DistributedNodeServiceName::Batcher
?
Code quote:
ConsolidatedNode(ConsolidatedNodeServiceName::Node)
798d709
to
a5e5434
Compare
25df850
to
6a77f4e
Compare
a5e5434
to
0789a77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
0789a77
to
1c2f108
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
No description provided.