chore(starknet_sequencer_node): remove redundant lifetime generics #5031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2025
|
This change is |
This was referenced Mar 18, 2025
Itay-Tsabary-Starkware
force-pushed
the
03-18-chore_starknet_sequencer_node_bundle_all_deployments_in_an_array
branch
2 times, most recently
from
6f84883 to
a2f4a26
Compare
Itay-Tsabary-Starkware
force-pushed
the
03-18-chore_starknet_sequencer_node_remove_redundant_lifetime_generics
branch
from
16a2241 to
2a1f253
Compare
Itay-Tsabary-Starkware
force-pushed
the
03-18-chore_starknet_sequencer_node_bundle_all_deployments_in_an_array
branch
from
a2f4a26 to
c0b37e4
Compare
Itay-Tsabary-Starkware
force-pushed
the
03-18-chore_starknet_sequencer_node_remove_redundant_lifetime_generics
branch
from
2a1f253 to
e03950d
Compare
Itay-Tsabary-Starkware
changed the base branch from
03-18-chore_starknet_sequencer_node_bundle_all_deployments_in_an_array
to
graphite-base/5031
Itay-Tsabary-Starkware
force-pushed
the
03-18-chore_starknet_sequencer_node_remove_redundant_lifetime_generics
branch
from
e03950d to
6adecb5
Compare
Itay-Tsabary-Starkware
force-pushed
the
03-18-chore_starknet_sequencer_node_remove_redundant_lifetime_generics
branch
from
6adecb5 to
a4b2d95
Compare
Itay-Tsabary-Starkware
force-pushed
the
03-18-chore_starknet_sequencer_node_remove_redundant_lifetime_generics
branch
from
a4b2d95 to
01973ad
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r3.
Reviewable status:
nadin-Starkware
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.