Skip to content

chore(starknet_sequencer_node): add derive annotations #5043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Itay-Tsabary-Starkware commented Mar 18, 2025

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment branch from d67adbb to 1bc35a9 Compare March 19, 2025 05:57
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_derive_app_config_name_from_service branch 2 times, most recently from 96dcbdd to 23ffa2e Compare March 19, 2025 06:21
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment branch 2 times, most recently from 20174ee to f62aca5 Compare March 19, 2025 07:53
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from 03-18-chore_starknet_sequencer_node_derive_app_config_name_from_service to graphite-base/5043 March 19, 2025 13:25
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment branch from f62aca5 to 4a1dcc3 Compare March 19, 2025 13:25
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from graphite-base/5043 to 03-19-chore_starknet_sequencer_node_remove_redundant_port_allocation March 19, 2025 13:25
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-19-chore_starknet_sequencer_node_remove_redundant_port_allocation branch 2 times, most recently from 35fb4a9 to 9a40d7d Compare March 19, 2025 19:03
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment branch from 4a1dcc3 to 141556c Compare March 19, 2025 19:03
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from 03-19-chore_starknet_sequencer_node_remove_redundant_port_allocation to graphite-base/5043 March 19, 2025 19:50
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment branch from 141556c to 4b08fa3 Compare March 19, 2025 19:50
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from graphite-base/5043 to 03-19-chore_starknet_integration_tests_delete_redundant_mempool_p2p_config_gen_fn March 19, 2025 19:50
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment branch from 4b08fa3 to 44c500d Compare March 19, 2025 19:56
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title chore(starknet_sequencer_node): create component configs in deployment chore(starknet_sequencer_node): add derive annotations Mar 20, 2025
Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from 03-19-chore_starknet_integration_tests_delete_redundant_mempool_p2p_config_gen_fn to graphite-base/5043 March 20, 2025 07:41
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment branch from 44c500d to 65e63f2 Compare March 20, 2025 07:41
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from graphite-base/5043 to main March 20, 2025 07:41
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit ef10178 Mar 20, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants