Fix: 5159, 5169, 5171, 5172, and others#5191

Merged

jcnelson merged 29 commits intodevelopfrom fix/5159

Sep 16, 2024

+2,095-1,375

Commits on Sep 16, 2024

chore: stdext and rlimit dev-dependencies
jcnelson
committed
bugfix: always save new neighbor data when we get it
jcnelson
committed
chore: reduce some debug noise, and log connection name for bandwidth-exceeded conditions
jcnelson
committed
chore: document neighbor walk connection opts, and add log_neighbors_Freq and walk_seed_probability options
jcnelson
committed
fix: if we're not in IBD and we dno't have a seed node connection (which can happen due to misconfiguration), then still occasionally attempt to walk to non-seed nodes (fixes #5159 )
jcnelson
committed
fix: collate peers by public key and only report the one with the latest last-contact time. Don't query rows in frontier directly, unless it's for a specific slot (fixes #5169 )
jcnelson
committed
feat: log all p2p conversations every log_neighbor_freq milliseconds
jcnelson
committed
fix: when discovering a new neighbor, don't replace its inbound peer address with its outbound address if both addresses are private. Also, log more walk instantiation data
jcnelson
committed
fix: don't forward stackerdb chunks that are known to be locally stale
jcnelson
committed
chore: log the neighbor address which sent the chunk
jcnelson
committed
fix: check local rc_consensus_hash against rc_consensus_hash of a scheduled message we're about to send, and abort stackerdb sync if they differ (indicates that the p2p network advanced its stacker…
jcnelson
committed
fix/refactor: make it so the small-scale neighbor tests will bind to a kernel-chosen port (avoids clobbering), and move topology tests to integration test CI
jcnelson
committed
fix: sort_unstable_by() for sorting peers by health, since our comparison function is not a total order (oops)
jcnelson
committed
chore: add pathological reward cycles to downloader tests where the only sortitions in the reward cycle are to confirm the anchor block
jcnelson
committed
build: build tests with feature = "testing", and disable unused warnings for tests
jcnelson
committed
chore: add dev-dependencies that will allow test modules to compile for stackslib when it's a dependency (e.g. so stackslib test code can be used in stacks-node tests)
jcnelson
committed
build: use feature = "testing" to build stackslib test code, and suppress unused warnings in tests
jcnelson
committed
build: plumb through features
jcnelson
committed
build: buidl stackslib and deps with "testing" feature so we can use stackslib test code in integration tests
jcnelson
committed
chore: expose walk_seed_probability and log_neighbors_freq connection opts
jcnelson
committed
chore: move topology neighbor convergence tests to integration test CI
jcnelson
committed
chore: activate p2p convergence tests
jcnelson
committed
Merge branch 'develop' into fix/5159
jcnelson
committed
Merge branch 'develop' into fix/5159
jcnelson
authored
Merge branch 'develop' into fix/5159
jcnelson
authored
Merge branch 'develop' into fix/5159
jcnelson
authored
chore: move p2p::conv tests back to stackslib
kantai
committed
chore: last cleanup from p2p::conv test movement
kantai
committed
Add new workflow for p2p convergence tests
wileyj
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: 5159, 5169, 5171, 5172, and others#5191

Commits on Sep 16, 2024

chore: stdext and rlimit dev-dependencies

bugfix: always save new neighbor data when we get it

chore: reduce some debug noise, and log connection name for bandwidth-exceeded conditions

chore: document neighbor walk connection opts, and add `log_neighbors_Freq` and `walk_seed_probability` options

fix: if we're not in IBD and we dno't have a seed node connection (which can happen due to misconfiguration), then still occasionally attempt to walk to non-seed nodes (fixes #5159 )

fix: collate peers by public key and only report the one with the latest last-contact time. Don't query rows in `frontier` directly, unless it's for a specific `slot` (fixes #5169 )

feat: log all p2p conversations every `log_neighbor_freq` milliseconds

fix: when discovering a new neighbor, don't replace its inbound peer address with its outbound address if both addresses are private. Also, log more walk instantiation data

fix: don't forward stackerdb chunks that are known to be locally stale

chore: log the neighbor address which sent the chunk

fix: check local rc_consensus_hash against rc_consensus_hash of a scheduled message we're about to send, and abort stackerdb sync if they differ (indicates that the p2p network advanced its stacker…

fix/refactor: make it so the small-scale neighbor tests will bind to a kernel-chosen port (avoids clobbering), and move topology tests to integration test CI

fix: sort_unstable_by() for sorting peers by health, since our comparison function is not a total order (oops)

chore: add pathological reward cycles to downloader tests where the only sortitions in the reward cycle are to confirm the anchor block

build: build tests with `feature = "testing"`, and disable unused warnings for tests

chore: add dev-dependencies that will allow test modules to compile for stackslib when it's a dependency (e.g. so stackslib test code can be used in stacks-node tests)

build: use `feature = "testing"` to build stackslib test code, and suppress `unused` warnings in tests

build: plumb through features

build: buidl stackslib and deps with "testing" feature so we can use stackslib test code in integration tests

chore: expose walk_seed_probability and log_neighbors_freq connection opts

chore: move topology neighbor convergence tests to integration test CI

chore: activate p2p convergence tests

Merge branch 'develop' into fix/5159

Merge branch 'develop' into fix/5159

Merge branch 'develop' into fix/5159

Merge branch 'develop' into fix/5159

chore: move p2p::conv tests back to stackslib

chore: last cleanup from p2p::conv test movement

Add new workflow for p2p convergence tests