Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Network] inbound neighbor walk is broken #5159

Closed
jcnelson opened this issue Sep 10, 2024 · 2 comments
Closed

[Network] inbound neighbor walk is broken #5159

jcnelson opened this issue Sep 10, 2024 · 2 comments
Assignees
@jcnelson
Labels
3.0-must 3.0-Testing 3.0 locked
Milestone
Nakamoto 3.0 - Te...

Comments

@jcnelson
Copy link
Member

It appears that there has been a behavioral regression in the node's neighbor walk algorithm. It ought to be the case that if node A contacts node B, then node B should attempt to contact node A, and if successful, add node A to its outbound peer set (making it eligible for data pushed from node B, and eligible for enumeration in response to a GetNeighbors p2p message). This isn't happening anymore.
@jcnelson jcnelson added the 3.0 label Sep 10, 2024
@jcnelson jcnelson self-assigned this Sep 10, 2024
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Sep 10, 2024
@saralab
Copy link
Contributor

saralab commented Sep 13, 2024

Misconfiguration could be the problem. Still needs to be evaluated on a testnet

jcnelson added a commit that referenced this issue Sep 16, 2024
@jcnelson
fix: if we're not in IBD and we dno't have a seed node connection (wh…
71bdd84 
…ich can happen due to misconfiguration), then still occasionally attempt to walk to non-seed nodes (fixes #5159)
@jcnelson jcnelson mentioned this issue Sep 16, 2024
Merged
@saralab saralab moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Sep 17, 2024
@saralab saralab closed this as completed Sep 17, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jcnelson jcnelson

Labels
3.0-must 3.0-Testing 3.0 locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
Nakamoto 3.0 - Testnet Readiness
Development

No branches or pull requests
3 participants
@saralab @jcnelson @blockstack-devops